Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host: E2e test env #447

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Host: E2e test env #447

wants to merge 7 commits into from

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 10, 2025

Issue:

Description of changes:

  • full refactor tests to use helper functions
  • refactor tests to use a single test block instead of shared browser context
  • update global setup to create bceid auth state in test env (using otp)
  • fix typo 'First Nations' -> 'First Nation'
Screen.Recording.2025-01-10.at.2.02.16.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-447-9cl6a5r6.web.app

2 similar comments
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-447-9cl6a5r6.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-447-9cl6a5r6.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-447-9cl6a5r6.web.app

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
21.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-447-9cl6a5r6.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants