hosts drafts #442

kialj876 · 2025-01-08T20:33:27Z

Issue:

UI: Save Draft / Load Draft / Delete Draft entity#25154

Description of changes:

~~just waiting on delete draft endpoint~~ All set

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Signed-off-by: Kial Jinnah <[email protected]>

kialj876 · 2025-01-08T20:36:47Z

strr-base-web/app/components/connect/ButtonControl.vue

with 3 extra buttons I needed to update the styling for smaller screens

example:

bcregistry-sre · 2025-01-08T20:36:53Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

kialj876 · 2025-01-08T20:37:31Z

strr-base-web/app/components/todo/Index.vue

-        :icon="button.icon"
-        @click="button.action()"
-      />
+      <div>


wrapped the button in a div to prevent it growing with the width of the row

strr-host-pm-web/app/pages/application.vue

kialj876 · 2025-01-08T20:41:09Z

strr-host-pm-web/app/pages/dashboard/index.vue

examples of new buttons / styling on big + small screens:
big screen

drop down

smaller screen

strr-host-pm-web/app/pages/application.vue

strr-host-pm-web/app/pages/dashboard/index.vue

bcregistry-sre · 2025-01-09T15:26:49Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

kialj876 · 2025-01-09T15:27:32Z

strr-base-web/app/components/connect/form/date/Picker.vue

+@use '@vuepic/vue-datepicker/dist/main.css' as *;
+@use 'tailwindcss/base' as *;
+@use 'tailwindcss/components' as *;
+@use 'tailwindcss/utilities' as *;


@import depreciated

kialj876 · 2025-01-09T15:29:00Z

strr-base-web/app/components/connect/form/phoneNumber/CountryCode.vue

+    } else {
+      selectedCountry.value = {
+        callingCode: countryCallingCode.value,
+        label: `+${countryCallingCode.value}`


when loading from a draft we need this because the api doesn't save the iso2 for the phone number. Was resulting in weird functionality when re-editing an existing person with a phone number

kialj876 · 2025-01-09T15:31:40Z

strr-base-web/app/composables/useButtonControl.ts

alternatively we could just have these in a util like before. I like this a bit more because I think it's clearer where the 'buttonControl' functionality lives

kialj876 · 2025-01-09T15:32:01Z

strr-base-web/app/utils/setButtonControl.ts

moved to composable

kialj876 · 2025-01-09T15:33:39Z

strr-host-pm-web/app/components/connect/form/phoneNumber/CountryCode.vue

was able to remove this and build successfully (there was some weird issue before where we needed this component defined in each layer otherwise it would give a build error)

…ix, other fixes Signed-off-by: Kial Jinnah <[email protected]>

bcregistry-sre · 2025-01-09T15:39:21Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

bcregistry-sre · 2025-01-09T15:39:41Z

Temporary Url for review: https://strr-platform-dev--pr-442-4zrdrl5t.web.app

bcregistry-sre · 2025-01-09T15:39:41Z

Temporary Url for review: https://strr-strata-hotel-dev--pr-442-727uskx8.web.app

bcregistry-sre · 2025-01-09T15:39:50Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

Signed-off-by: Kial Jinnah <[email protected]>

bcregistry-sre · 2025-01-09T16:53:13Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

bcregistry-sre · 2025-01-09T16:53:31Z

Temporary Url for review: https://strr-strata-hotel-dev--pr-442-727uskx8.web.app

bcregistry-sre · 2025-01-09T16:53:52Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

bcregistry-sre · 2025-01-09T16:54:08Z

Temporary Url for review: https://strr-platform-dev--pr-442-4zrdrl5t.web.app

Signed-off-by: Kial Jinnah <[email protected]>

bcregistry-sre · 2025-01-09T17:09:17Z

Temporary Url for review: https://strr-strata-hotel-dev--pr-442-727uskx8.web.app

bcregistry-sre · 2025-01-09T17:09:26Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

bcregistry-sre · 2025-01-09T17:09:46Z

Temporary Url for review: https://strr-platform-dev--pr-442-4zrdrl5t.web.app

bcregistry-sre · 2025-01-09T17:09:58Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

deetz99 · 2025-01-09T17:24:48Z

strr-host-pm-web/app/pages/dashboard/index.vue

+async function deleteDraft (row: any) {
+  try {
+    deleting.value = true
+    row.class = 'bg-red-50 animate-pulse'


deetz99 · 2025-01-09T17:30:27Z

strr-host-pm-web/app/pages/dashboard/index.vue

+                        ? row.address.unitNumber + '-'
+                        : ''}${row.address.streetNumber} ${row.address.streetName}, ${row.address.city}`
+                      : '',
+                    number: row.applicationNumber


I'm not seeing number as a prop in the locale string?

deetz99

Looks pretty good!

Only concern is on that aria label still. Maybe something like
btn.resumeDraftAria: 'Resume Draft for {number}'. ?

Also need to bump version for all apps.

Great work 👍

kialj876 · 2025-01-09T19:00:05Z

Looks pretty good!

Only concern is on that aria label still. Maybe something like btn.resumeDraftAria: 'Resume Draft for {number}'. ?

Also need to bump version for all apps.

Great work 👍

Oh oops yeah good catch

Signed-off-by: Kial Jinnah <[email protected]>

deetz99

Looks good! 👍

bcregistry-sre · 2025-01-09T19:08:02Z

Temporary Url for review: https://strr-strata-hotel-dev--pr-442-727uskx8.web.app

bcregistry-sre · 2025-01-09T19:08:36Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

bcregistry-sre · 2025-01-09T19:08:42Z

Temporary Url for review: https://strr-platform-dev--pr-442-4zrdrl5t.web.app

bcregistry-sre · 2025-01-09T19:08:50Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

Signed-off-by: Kial Jinnah <[email protected]>

sonarqubecloud · 2025-01-09T19:27:24Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bcregistry-sre · 2025-01-09T19:29:48Z

Temporary Url for review: https://strr-examiner-dev--pr-442-oal1esie.web.app

bcregistry-sre · 2025-01-09T19:30:05Z

Temporary Url for review: https://strr-platform-dev--pr-442-4zrdrl5t.web.app

bcregistry-sre · 2025-01-09T19:30:14Z

Temporary Url for review: https://strr-strata-hotel-dev--pr-442-727uskx8.web.app

bcregistry-sre · 2025-01-09T19:30:21Z

Temporary Url for review: https://strr-hosts-dev--pr-442-q6k9hp9k.web.app

hosts drafts

1dae36c

Signed-off-by: Kial Jinnah <[email protected]>

kialj876 requested a review from deetz99 January 8, 2025 20:33

kialj876 commented Jan 8, 2025

View reviewed changes

strr-host-pm-web/app/pages/application.vue Outdated Show resolved Hide resolved

kialj876 commented Jan 8, 2025

View reviewed changes

deetz99 reviewed Jan 8, 2025

View reviewed changes

strr-host-pm-web/app/pages/application.vue Outdated Show resolved Hide resolved

deetz99 reviewed Jan 8, 2025

View reviewed changes

strr-host-pm-web/app/pages/dashboard/index.vue Outdated Show resolved Hide resolved

kialj876 commented Jan 9, 2025

View reviewed changes

strr-base-web/app/utils/setButtonControl.ts Outdated

Copy link

Collaborator Author

kialj876 Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to composable

kialj876 commented Jan 9, 2025

View reviewed changes

feature flag, phone number issue, btn control updates, depreciation f…

fc1eb29

…ix, other fixes Signed-off-by: Kial Jinnah <[email protected]>

kialj876 force-pushed the 25154-drafts branch from cc007d5 to fc1eb29 Compare January 9, 2025 15:36

added delete draft call

5d60f59

Signed-off-by: Kial Jinnah <[email protected]>

fix for base-web ci?

bf828f9

Signed-off-by: Kial Jinnah <[email protected]>

kialj876 marked this pull request as ready for review January 9, 2025 17:11

deetz99 reviewed Jan 9, 2025

View reviewed changes

deetz99 approved these changes Jan 9, 2025

View reviewed changes

Update for PR comment

4e6660c

Signed-off-by: Kial Jinnah <[email protected]>

deetz99 approved these changes Jan 9, 2025

View reviewed changes

cleanup

d4531af

Signed-off-by: Kial Jinnah <[email protected]>

kialj876 merged commit d37eb5b into bcgov:main Jan 9, 2025
43 checks passed

hosts drafts #442

hosts drafts #442

Conversation

kialj876 commented Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

bcregistry-sre commented Jan 8, 2025

Choose a reason for hiding this comment

kialj876 Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

bcregistry-sre commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deetz99 left a comment

Choose a reason for hiding this comment

kialj876 commented Jan 9, 2025

deetz99 left a comment

Choose a reason for hiding this comment

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

sonarqubecloud bot commented Jan 9, 2025

Quality Gate passed

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

bcregistry-sre commented Jan 9, 2025

kialj876 commented Jan 8, 2025 •

edited

Loading

kialj876 Jan 8, 2025 •

edited

Loading