Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Examiner Dashboard #411

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Updates to Examiner Dashboard #411

merged 9 commits into from
Dec 20, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Dec 19, 2024

Issue:

Description of changes:

  • Updates to Examiner Dashboard based on wip designs

Dashboard

Screenshot 2024-12-19 at 15 04 18

Details / Examine

Screenshot 2024-12-19 at 15 04 27

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@dimak1 dimak1 requested a review from deetz99 December 19, 2024 23:10
@dimak1 dimak1 self-assigned this Dec 19, 2024
@dimak1 dimak1 requested a review from thorwolpert December 19, 2024 23:10
:heading="{
label: 'Registration Details',
labelClass: 'font-bold',
icon: 'mdi-file-document-tick-outline'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon should have 'i-' prefix, so this should be 'i-mdi-file-document-tick-outline'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

[ApplicationType.STRATA_HOTEL]: 'Strata Hotel'
}

const { header, registration } = toRefs(props.application)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if the toRefs is necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it is not needed. The component itself is not needed and will be cleaned up.

Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dimak1 dimak1 merged commit a07c9ed into bcgov:main Dec 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants