-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Examiner Dashboard #411
Conversation
:heading="{ | ||
label: 'Registration Details', | ||
labelClass: 'font-bold', | ||
icon: 'mdi-file-document-tick-outline' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon should have 'i-' prefix, so this should be 'i-mdi-file-document-tick-outline'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
[ApplicationType.STRATA_HOTEL]: 'Strata Hotel' | ||
} | ||
|
||
const { header, registration } = toRefs(props.application) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if the toRefs is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea it is not needed. The component itself is not needed and will be cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
3738179
to
b4a0ee3
Compare
Quality Gate passedIssues Measures |
Issue:
Description of changes:
Dashboard
Details / Examine
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).