Strata - UI: Strata dashboard list #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporary Url for review: https://strr-platform-dev--pr-285-mfuh9g2p.web.app |
1 similar comment
|
Temporary Url for review: https://strr-platform-dev--pr-285-mfuh9g2p.web.app |
kialj876
approved these changes
Nov 7, 2024
| page: { | ||
| login: { | ||
| redirectPath: '/auth/account/choose-existing' | ||
| // options: { // allow all options? |
There was a problem hiding this comment.
good question I think we should allow everything for now
strr-strata-web/app/stores/strata.ts
Outdated
| ).map(app => ({ | ||
| hotelName: app.registration.strataHotelDetails.brand.name, | ||
| number: app.header.applicationNumber, | ||
| type: 'Application', |
There was a problem hiding this comment.
probably would be good to have this and 'Registration' come from i18n?
| })) | ||
| } | ||
| return [] | ||
| }) |
kialj876
reviewed
Nov 7, 2024
|
|
Temporary Url for review: https://strr-platform-dev--pr-285-mfuh9g2p.web.app |
1 similar comment
|
Temporary Url for review: https://strr-platform-dev--pr-285-mfuh9g2p.web.app |
kialj876
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the strr2 license (Apache 2.0).