Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Payment Fail Banner and ApplicationDetails Unit Test #283

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shaangill025
Copy link
Collaborator

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@shaangill025 shaangill025 self-assigned this Nov 7, 2024
@shaangill025

This comment was marked as outdated.

@bcregistry-sre

This comment was marked as outdated.

@shaangill025

This comment was marked as outdated.

@shaangill025 shaangill025 marked this pull request as ready for review November 7, 2024 17:04
@bcregistry-sre

This comment was marked as outdated.

@shaangill025 shaangill025 marked this pull request as draft November 7, 2024 17:05
@shaangill025

This comment was marked as outdated.

@bcregistry-sre

This comment was marked as outdated.

@shaangill025 shaangill025 marked this pull request as ready for review November 7, 2024 17:18
@shaangill025

This comment was marked as outdated.

@bcregistry-sre

This comment was marked as outdated.

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

strr-web/components/bcros/form-section/BusinessDetails.vue Outdated Show resolved Hide resolved
strr-web/tests/mocks/mockApplication.ts Outdated Show resolved Hide resolved
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

@shaangill025
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-ui-dev--pr-283-oopj1wep.web.app

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Thanks for the unit tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants