UI - strata hotel application #274
Conversation
Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
|
Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app |
| @@ -18,7 +18,9 @@ defineProps({ | |||
| }) | |||
|
|
|||
| const normalize = () => { | |||
| model.value = normalizeInput(model.value) | |||
| if (typeof model.value === 'string') { | |||
| model.value = normalizeInput(model.value) | |||
There was a problem hiding this comment.
Just wondering if using the .trim accomplishes the same thing? The only thing it doesn't do is replace undefined with an empty string
There was a problem hiding this comment.
oooh nice yeah I'll try that
Signed-off-by: Kial Jinnah <[email protected]>
|
Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app |
| @@ -27,7 +26,7 @@ export const useStrrStrataApplicationStore = defineStore('strr/strataApplication | |||
|
|
|||
| const validateStrataConfirmation = (returnBool = false): MultiFormValidationResult | boolean => { | |||
| const result = validateSchemaAgainstState( | |||
| getConfirmationSchema(), platformConfirmation, 'platform-confirmation-form' | |||
| confirmationSchema, confirmation, 'platform-confirmation-form' | |||
There was a problem hiding this comment.
Should we update this id to 'strata-confirmation-form' just to avoid confusion?
There was a problem hiding this comment.
yes definitely, I will update
There was a problem hiding this comment.
Cool, other than looks good! 🎉
Signed-off-by: Kial Jinnah <[email protected]>
|
|
Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app |
1 similar comment
|
Temporary Url for review: https://strr-platform-dev--pr-274-nevq2lox.web.app |
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).