Strr2 - Draft Terms of Service #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Temporary Url for review: https://strr-platform-dev--pr-260-rot4j3r2.web.app |
1 similar comment
|
Temporary Url for review: https://strr-platform-dev--pr-260-rot4j3r2.web.app |
thorwolpert
approved these changes
Nov 1, 2024
| @@ -19,6 +19,7 @@ NUXT_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/" | |||
| NUXT_PAYMENT_PORTAL_URL="https://dev.account.bcregistry.gov.bc.ca/makepayment/" | |||
| NUXT_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/" | |||
| NUXT_BASE_URL="http://localhost:3000/" # app base url | |||
| NUXT_HOUSING_STRR_URL="" # TODO: add housing strr base url here for redirects | |||
There was a problem hiding this comment.
Did you want to add that to https://github.com/bcgov/STRR/blob/main/strr-platform-web/devops/vaults.env
or I can in another PR?
kialj876
approved these changes
Nov 4, 2024
| termsOfUse: string | ||
| } | ||
|
|
||
| // TODO: make this generic for the core layer? |
There was a problem hiding this comment.
Yeah I think this would be good there. Might be good to prefix this with 'connect' if we're going to do that. For now we could put it in the strr base layer and figure out the kinks before moving it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Will probably close this and create a new pr for the base layer instead but take a look and let me know what you think.
Did not add i18n stuff because this will need to be moved to the base layer.
Side question: How do we want to set breadcrumbs on pages from the layer?
Steps to reproduce:
https://strr-api-dev-i2rbretwta-nn.a.run.app/users/tos(account id not required) with the following payloadBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the strr license (Apache 2.0).