Platform - UI: simplify auth setup function #230
Draft
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deetz99
changed the title
|
Temporary Url for review: https://strr-platform-dev--pr-230-1r1rb2en.web.app |
thorwolpert
approved these changes
Oct 26, 2024
kialj876
approved these changes
Oct 28, 2024
| await expect(page.getByRole('menuitem', { name: 'IDIR' })).toBeVisible() // will need to change this to BCeID | ||
| await page.getByRole('menuitem', { name: 'IDIR' }).click() | ||
| // replace with environment variable? | ||
| const signinUrl = 'https://dev.account.bcregistry.gov.bc.ca/signin/bceid/' |
There was a problem hiding this comment.
yeah I think we could do ${...NUXT_AUTH_WEB_URL -- I think this maps to authWebURL?}/signin/bceid
There was a problem hiding this comment.
I'm just thinking if this is actually better than what I had previously or not.
Pros:
- handles login for dev/test/prod without concerning the test runner with any middleware changes etc we make
- less steps, marginally faster
Cons:
- we're relying on auth-web to never change this url redirect
I doubt that will change anytime soon but 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).