-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NodeJS backend dependencies. #214
Open
trev-dev
wants to merge
32
commits into
master
Choose a base branch
from
fix/HD-26946
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest versions of our dependencies now expect ESM over CommonJS. I made the conversion because this is the current standard
Moved these from exported object interfaces into module interfaces
Quality Gate passedIssues Measures |
Prevents accidental glob expansion in shell commands
trev-dev
force-pushed
the
fix/HD-26946
branch
2 times, most recently
from
September 3, 2024 23:22
d4c1cec
to
12955e7
Compare
trev-dev
force-pushed
the
fix/HD-26946
branch
from
September 3, 2024 23:27
12955e7
to
05400e5
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: HD-26946
The goal of this pull request is to update the NodeJS backend and its dependencies. Due to some of the updates being incompatible with CommonJS modules, I opted to refactor the backend into the ESM (EcmaScript Module) format. This is the standard for JavaScript, whereas CJS was more of a node/webpack/bundler thing.
Breaking changes for nats and passport have been addressed as well. Check the commit messages, I tried to keep things granular.
Jest was also dropped in favor of Vitest. Vitest is actually prepared to test ESM files. This change removed a great deal of bloat from the dependency tree and sped up tests a great deal.