Merge pull request #284 from bcgov/grad-release

Grad release 1.23.1
bcgov · Sep 16, 2024 · 945879d · 945879d
2 parents 4a26ac3 + e3616d7
commit 945879d
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/api/src/main/java/ca/bc/gov/educ/api/grad/report/model/dto/StudentSearchRequest.java b/api/src/main/java/ca/bc/gov/educ/api/grad/report/model/dto/StudentSearchRequest.java
@@ -2,6 +2,7 @@
 
 import ca.bc.gov.educ.api.grad.report.util.EducGradReportApiConstants;
 import com.fasterxml.jackson.annotation.JsonFormat;
+import com.fasterxml.jackson.annotation.JsonIgnore;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
@@ -41,13 +42,13 @@ public class StudentSearchRequest implements Serializable {
     String activityCode;
     String localDownload;
 
+    @JsonIgnore
     public boolean isEmpty() {
-        return  schoolOfRecords.isEmpty() &&
-                districts.isEmpty() &&
-                schoolCategoryCodes.isEmpty() &&
-                pens.isEmpty() &&
-                studentIDs.isEmpty() &&
-                programs.isEmpty();
+        return  (schoolOfRecords == null || schoolOfRecords.isEmpty()) &&
+                (districts == null || districts.isEmpty()) &&
+                (schoolCategoryCodes == null || schoolCategoryCodes.isEmpty()) &&
+                (pens == null || pens.isEmpty()) &&
+                (studentIDs == null || studentIDs.isEmpty());
     }
 
 }