Fix unpacking time (unsigned int) from octets for large values #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time, as well as offsets (e.g. expiration) in OpenPGP are stored as seconds in unsigned Integers.
I noticed, that 8385a2c broke some tests in PGPainless that dealt with large expiration time intervals.
Turns out, the changed code accidentally converted the values to signed ints, which break for large (but legal) intervals.
The patch converts back to an unsigned value.