Replace StringBuffer with StringBuilder #1756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngBuilder / StringJoiner / string-composition
…ngBuilder / StringJoiner / string-composition
…ngBuilder / StringJoiner / string-composition
…ngBuilder / StringJoiner / string-composition. Make loop variables "final" to leverage compiler bytecode inlining
…ngBuilder / StringJoiner / string-composition. Make loop variables "final" to leverage compiler bytecode inlining
…ngBuilder / StringJoiner / string-composition.
…ngJoiner with prefix "[", suffix "]" and separator ", "
…s of an iterable with a StringJoiner
…ia a new context-aware Appendable
…string by System's file separator, as it can lead to StringIndexOutOfBoundException in case the test folder does not exist
…string by System's file separator, as it can lead to StringIndexOutOfBoundException in case the test folder does not exist
Correct bad syntax
hubot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuffer is a synchronized Appendable, useful when more than one publisher is appending text to the same Appendable, but a waste of resources when the object is created and consumed by the same method (e.g. various
toString()).Furthermore, in Java 21+ synchronization interferes with the pinning of virtual threads on the carrier thread, potentially slowing down the application if, while locking an object, a suspendable operation is performed (e.g. IO read / write or
Thread.sleep())