Document OpenBSDBCrypt password handling
#1742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would also be good to apply this to https://github.com/bcgit/bc-csharp, but I am not familiar with C#. So if possible, could you do that please? |
Marcono1234
commented
Jul 21, 2024
| * of the reference implementation on OpenBSD | ||
| * of the reference implementation on OpenBSD. | ||
| * <p> | ||
| * Passwords are encoded using UTF-8. Encoded passwords longer than |
There was a problem hiding this comment.
Regarding UTF-8: Do you think this wording here is misleading and it should say that this only applies when the password is provided as char[] (but not when provided as byte[])? Or is it fine like this?
And do you think it is clear enough that the "encoded passwords longer than ..." applies as well when users provide an already encoded password as byte[]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the behavior was not explicitly documented, and it might not have been obvious that passwords longer than 72 bytes will be truncated.