Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NASAA-205] - Send top stories experiment analytics events #12075

Draft
wants to merge 8 commits into
base: latest
Choose a base branch
from
Draft

[NASAA-205] - Send top stories experiment analytics events #12075

wants to merge 8 commits into from
+269 −17

Commits on Oct 21, 2024

  1. Add amp-analytics to AmpExperiment

    @hotinglok
    hotinglok committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7625d2d View commit details
    Browse the repository at this point in the history

  2. Add tests

    @hotinglok
    hotinglok committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ac4cd70 View commit details
    Browse the repository at this point in the history

  3. Remove commented out snapshot

    @hotinglok
    hotinglok committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ef8f7f1 View commit details
    Browse the repository at this point in the history

  4. Pass down & use producerId

    @hotinglok
    hotinglok committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a7cd6af View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Make selectors for event triggers more robust

    @hotinglok
    hotinglok committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6905317 View commit details
    Browse the repository at this point in the history

  2. Update selectors to account for secondary column section

    @hotinglok
    hotinglok committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5607655 View commit details
    Browse the repository at this point in the history

  3. Refactor scripts in AmpExperiment to use same component

    @hotinglok
    hotinglok committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    30f746f View commit details
    Browse the repository at this point in the history

  4. Cleanup of tests/types

    @hotinglok
    hotinglok committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    558bb5e View commit details
    Browse the repository at this point in the history