Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out Uzbek config for translation updates #12068

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Oct 21, 2024

Overall changes

  • Separates out the Uzbek service config so that editorial can more easily add/update translations
  • Removes spreading syntax in favour of more verbosity as this will be easier to understand for updating purposes

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Oct 21, 2024
Copy link
Contributor

@eagerterrier eagerterrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some Qs...

},
include: {
errorMessage:
'Sorry, we can’t display this part of the story on this lightweight mobile page.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a translation from editorial on this before merging? Not urgent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About half of the services have this in English. I can ask editorial if they have the translation to update it though.

{
id: 'COOKIE_SETTINGS',
href: '#',
text: 'Do not share or sell my info',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, about half of services have this in English, but can ask.

},
},
canonical: {
title: 'Кукис(Cookies)га рози эканингизни билдиринг',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right. Maybe it is. Just has feels of not right

src/app/lib/config/services/uzbek.ts Outdated Show resolved Hide resolved
bbc_uzbek_tv: {
title: 'Bi-bi-si O‘zbek - Afg‘oniston uchun TV dastur',
subtitle:
'Dastur haftada 5 kun - dushanbadan juma kuniga qadar Toshkent vaqti bilan soat 18.30 -18.40 da efirga uzatiladi',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be transliterated?

Copy link
Contributor Author

@amoore108 amoore108 Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep all the translations in lat are basically the cyr version, so it will be up to editorial to update these.

We aren't in a worse position than we currently are with this change. This change will just make it easier for editorial to update the translations as the spread syntax probably won't mean much to them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this looks like the wrong language to begin with?

Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - thanks!

@amoore108 amoore108 merged commit 4cc440b into latest Oct 22, 2024
11 checks passed
@amoore108 amoore108 deleted the uzbek-config-separate-out branch October 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants