-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out Uzbek config for translation updates #12068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some Qs...
src/app/lib/config/services/uzbek.ts
Outdated
}, | ||
include: { | ||
errorMessage: | ||
'Sorry, we can’t display this part of the story on this lightweight mobile page.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get a translation from editorial on this before merging? Not urgent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About half of the services have this in English. I can ask editorial if they have the translation to update it though.
src/app/lib/config/services/uzbek.ts
Outdated
{ | ||
id: 'COOKIE_SETTINGS', | ||
href: '#', | ||
text: 'Do not share or sell my info', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, about half of services have this in English, but can ask.
src/app/lib/config/services/uzbek.ts
Outdated
}, | ||
}, | ||
canonical: { | ||
title: 'Кукис(Cookies)га рози эканингизни билдиринг', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look right. Maybe it is. Just has feels of not right
bbc_uzbek_tv: { | ||
title: 'Bi-bi-si O‘zbek - Afg‘oniston uchun TV dastur', | ||
subtitle: | ||
'Dastur haftada 5 kun - dushanbadan juma kuniga qadar Toshkent vaqti bilan soat 18.30 -18.40 da efirga uzatiladi', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be transliterated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep all the translations in lat
are basically the cyr
version, so it will be up to editorial to update these.
We aren't in a worse position than we currently are with this change. This change will just make it easier for editorial to update the translations as the spread syntax probably won't mean much to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this looks like the wrong language to begin with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - thanks!
Overall changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines