Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1312 Run an Optimizely AA Test #12017

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

emilysaffron
Copy link
Contributor

@emilysaffron emilysaffron commented Sep 30, 2024

Resolves JIRA WSTEAM1-1312

Overall changes

Sets up a basic AA test for the srollablePromo component on an ArticlePage. This test has been set up in optimizely to only run on the swahili service. Both variations will return the same component.

Code changes

  • Wraps the article page in the optimizely provider
  • Applys the useOptimizelyVariation hook to the scrollable promo

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@emilysaffron emilysaffron self-assigned this Sep 30, 2024
Copy link
Contributor

@amoore108 amoore108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Presume it hinges on #11997 being merged first?

@emilysaffron
Copy link
Contributor Author

Looks good 👍 Presume it hinges on #11997 being merged first?

Yep will hold off on merging until that goes in 😊

@emilysaffron emilysaffron force-pushed the WSTEAM1-1312-run-optimizely-aatest branch from 4c83100 to 975943a Compare September 30, 2024 15:36
Copy link
Contributor

@HarveyPeachey HarveyPeachey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add in all the metric mechanisms, as I think they were removed in #11997, also need to setup the click and view tracking for the component with optimizely.

Happy to pair on it to get it working

@emilysaffron
Copy link
Contributor Author

I think we need to add in all the metric mechanisms, as I think they were removed in #11997, also need to setup the click and view tracking for the component with optimizely.

Happy to pair on it to get it working

by metric mechanisms do you mean like the scroll depth and article complete?

@HarveyPeachey
Copy link
Contributor

I think we need to add in all the metric mechanisms, as I think they were removed in #11997, also need to setup the click and view tracking for the component with optimizely.
Happy to pair on it to get it working

by metric mechanisms do you mean like the scroll depth and article complete?

Yeah and Page view tracking, also component click and views, you can get the Optimizely object that you pass into these hooks from context https://github.com/optimizely/react-sdk?tab=readme-ov-file#example-2

<OptimizelyArticleCompleteTracking />
<OptimizelyPageViewTracking />
useOptimizelyScrollDepth();

@emilysaffron emilysaffron merged commit 13b331b into latest Oct 1, 2024
11 checks passed
@emilysaffron emilysaffron deleted the WSTEAM1-1312-run-optimizely-aatest branch October 1, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants