Add stacktrace to ASSERTs (envoyproxy#38139)

Commit Message: Add stacktrace to ASSERTs
Additional Description: Before this change, ASSERTs provoke a
stacktrace, but it is always the useless two-line stacktrace
```
#0: sigHandler()
#1: restore_rt
```
as demonstrated by the test case added in this PR not passing before the
change.
It's a bit odd that after this change there will be two stacktraces
output on assert, but at least one of them will be useful.

Risk Level: Minimal, it's just output from asserts so if it does
anything it's during a crash anyway.
Testing: Added a test case, and used to debug my production issue which
I couldn't with the original version.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

---------

Signed-off-by: Raven Black <[email protected]>

source/common/common/assert.h

@@ -135,6 +135,9 @@ void resetEnvoyBugCountersForTest();
       ENVOY_LOG_TO_LOGGER(Envoy::Logger::Registry::getLog(Envoy::Logger::Id::assert), critical,    \
                           "assert failure: {}.{}{}", CONDITION_STR,                                \
                           details.empty() ? "" : " Details: ", details);                           \
+      Envoy::Assert::EnvoyBugStackTrace st;                                                        \
+      st.capture();                                                                                \
+      st.logStackTrace();                                                                          \
       ACTION;                                                                                      \
     }                                                                                              \
   } while (false)

test/common/common/assert_test.cc

@@ -7,6 +7,8 @@
 
 namespace Envoy {
 
+static void releaseAssertInAFunction() { RELEASE_ASSERT(0, ""); }
+
 TEST(ReleaseAssertDeathTest, VariousLogs) {
   EXPECT_DEATH({ RELEASE_ASSERT(0, ""); }, ".*assert failure: 0.*");
   EXPECT_DEATH({ RELEASE_ASSERT(0, "With some logs"); },
@@ -15,6 +17,18 @@ TEST(ReleaseAssertDeathTest, VariousLogs) {
                ".*assert failure: 0 == EAGAIN. Details: using fmt.*");
 }
 
+TEST(ReleaseAssertDeathTest, AssertIncludesStackTrace) {
+#ifdef NDEBUG
+  GTEST_SKIP() << "optimized build inlines functions so the stack trace won't be reliable";
+#endif
+#if defined(__has_feature)
+#if __has_feature(memory_sanitizer)
+  GTEST_SKIP() << "memory sanitizer build inlines functions so the stack trace won't be reliable";
+#endif
+#endif
+  EXPECT_DEATH({ releaseAssertInAFunction(); }, "releaseAssertInAFunction");
+}
+
 TEST(AssertDeathTest, VariousLogs) {
   int expected_counted_failures;
   // Use 2 assert action registrations to verify that action chaining is working correctly.