fix: make sys.executable work with script bootstrap #2409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--bootstrap_impl=script
is used,PYTHONPATH
is no longer used to set the importpaths, which means subprocesses no longer inherit the Bazel paths. This is generally a
good thing, but breaks when
sys.executable
is used to directly invoke the interpreter.Such an invocation assumes the interpreter will have the same packages available and works
with the system_python bootstrap.
To fix, have the script bootstrap use a virtual env. This allows it to intercept interpreter
startup even when the Bazel executable isn't invoked.
DO NOT MERGE:
##
markers from stage2 bootstrapFixes #2169