Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(toolchain): remove uname dep in the repository_rule stage #2406

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Nov 14, 2024

Before this PR we would shell out to uname on UNIX systems to get the arch
of the toolchain - on Windows we would not need to do it because there used to
be only a single Windows platform. With this change we can correctly support
the resolution of the python interpreter on various platforms and I have also
added an env variable to customize the selection, so that users can use musl
or a freethreaded interpreter if they wish.

As part of this change, I have restricted visibility of the config settings
used in the toolchain alias repo so that we are creating fewer targets. This is
a very good time to do this before 1.0.0.

Fixes #2145
Work towards #2276
Work towards #2386
Work towards #1211 to unblock #2402
Work towards #1361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting error indicating that uname is not in path on WSL
1 participant