refactor!(toolchain): remove uname dep in the repository_rule stage #2406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we would shell out to
uname
on UNIX systems to get thearch
of the toolchain - on Windows we would not need to do it because there used to
be only a single Windows platform. With this change we can correctly support
the resolution of the python interpreter on various platforms and I have also
added an env variable to customize the selection, so that users can use
musl
or a
freethreaded
interpreter if they wish.As part of this change, I have restricted visibility of the config settings
used in the toolchain alias repo so that we are creating fewer targets. This is
a very good time to do this before
1.0.0
.Fixes #2145
Work towards #2276
Work towards #2386
Work towards #1211 to unblock #2402
Work towards #1361