Skip to content

Commit

Permalink
chore!: remove requirements.txt for the twine publishing tool (#2401)
Browse files Browse the repository at this point in the history
`requirements_linux.txt` in the same folder should be used instead.

Fixes #2242
  • Loading branch information
aignas authored Nov 14, 2024
1 parent 541bcba commit c8ccd22
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 344 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ Unreleased changes template.

{#v0-0-0-removed}
### Removed
* Nothing yet.
* (publish) Remove deprecated `requirements.txt` for the `twine` dependencies.
Please use `requirements_linux.txt` instead.

{#v0-39-0}
## [0.39.0] - 2024-11-13
Expand Down
2 changes: 1 addition & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ pip_parse(
name = "rules_python_publish_deps",
python_interpreter_target = interpreter,
requirements_darwin = "//tools/publish:requirements_darwin.txt",
requirements_lock = "//tools/publish:requirements.txt",
requirements_lock = "//tools/publish:requirements_linux.txt",
requirements_windows = "//tools/publish:requirements_windows.txt",
)

Expand Down
1 change: 0 additions & 1 deletion private/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ multirun(
"//tools/publish:{}.update".format(r)
for r in [
"requirements_universal",
"requirements",
"requirements_darwin",
"requirements_windows",
"requirements_linux",
Expand Down
2 changes: 0 additions & 2 deletions tools/publish/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ filegroup(
name = "distribution",
srcs = [
"BUILD.bazel",
"requirements.txt",
"requirements_darwin.txt",
"requirements_linux.txt",
"requirements_universal.txt",
Expand All @@ -33,7 +32,6 @@ publish_deps(
name = "requirements",
srcs = ["requirements.in"],
outs = {
"requirements.txt": "linux", # TODO: maybe deprecate
"requirements_darwin.txt": "macos",
"requirements_linux.txt": "linux",
"requirements_universal.txt": "", # universal
Expand Down
Loading

0 comments on commit c8ccd22

Please sign in to comment.