fix: allow license_text=None in license declaration #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the build (or cquery) to fail with
every rule of type _license implicitly depends upon the target '//rules:LICENSE',
but this target could not be found because of: no such target '//rules:LICENSE'
Relates-to bazelbuild#31
There are many situations where the license kind is known but no license file is available, e.g. some wheels downloaded from PyPi. There are good reasons why one might want to prohibit that from a policy perspective, but enforcing that policy is not the job of the license rule itself, and the provided error message is not especially helpful (and clearly not the intended outcome). This doesn't alter the macro wrapper. Any target that would be affected by this change would have already been failing to build. Closes bazelbuild#31
adam-azarchs
commented
Oct 22, 2024
| ":hello_cc_copyrights.txt", | ||
| ":hello_licenses.json", |
There was a problem hiding this comment.
I debated reverting these off-target changes that were made by buildifier, but... they were made by buildifier, so probably best to leave them in anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
There are many situations where the license kind is known but no license
file is available, e.g. some wheels downloaded from PyPi.
There are good reasons why one might want to prohibit that from a policy
perspective, but enforcing that policy is not the job of the license
rule itself, and the provided error message is not especially helpful
(and clearly not the intended outcome).
This doesn't alter the macro wrapper. Any target that would be affected
by this change would have already been failing to build.