Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --output=commands flag for aquery #24949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support --output=commands flag for aquery #24949

wants to merge 1 commit into from
+85 −5

Conversation

pcc
Copy link

@pcc pcc commented Jan 16, 2025

This output format prints a list of build commands with one command per line, similar to ninja -t commands. This is frequently useful when debugging build issues.

Fixes #22389.

@github-actions github-actions bot added team-Performance Issues for Performance teams team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jan 16, 2025
@meisterT meisterT requested a review from joeleba January 22, 2025 11:09
joeleba
joeleba requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@joeleba joeleba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

...java/com/google/devtools/build/lib/query2/aquery/ActionGraphTextOutputFormatterCallback.java Outdated Show resolved Hide resolved
@gregestren gregestren removed their request for review January 22, 2025 18:54
@pcc
Support --output=commands flag for aquery
a7d3d3d 
This output format prints a list of build commands with one command
per line, similar to `ninja -t commands`. This is frequently useful
when debugging build issues.

Fixes bazelbuild#22389.
@pcc pcc force-pushed the output-commands branch from 6400279 to a7d3d3d Compare January 23, 2025 00:10
@joeleba joeleba added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeleba joeleba joeleba approved these changes

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

Assignees
No one assigned
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aquery output format with one command per line
2 participants
@pcc @joeleba