notify: Wait on subprocess so that ProcessState is populated
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Notify code path bazel-watcher uses `os.ProcessState` to determine if a process is still running. However, it never calls `Wait` or `Run`, like it does in the normal codepath. This patch adds an async goroutine that `Wait`s for the subprocess to exisit so that `ProcessState` is populated correctly. Without this change subprocesses that exit result in bazel-watcher never detecting that the process is dead and trying to write to it continuously, which causes broken pipe errors in macOS/Linux.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Notify code path bazel-watcher uses
os.ProcessStateto determine if a process is still running. However, it never callsWaitorRun, like it does in the normal codepath. This patch adds an async goroutine thatWaits for the subprocess to exisit so thatProcessStateis populated correctly.Without this change subprocesses that exit result in bazel-watcher never detecting that the process is dead and trying to write to it continuously, which causes broken pipe errors in macOS/Linux, and broken builds until bazel-watcher is restarted.