Handle header patterns that start with "**/" #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some podspecs just include all files under their directory (eg [RCTText](https://github.com/facebook/react-native/blob/0.61-stable/Libraries/Text/React-RCTText.podspec#L30)). This breaks PodToBUILD both during generation (it passed an empty string to `fileManager.subpathsOfDirectory`, which threw an error) and at runtime (it double included the `pod_support` headers, which caused Bazel to fail). This fixes both of those issues.
FuegoFro
commented
Jan 28, 2020
| if lib.isTopLevelTarget { | ||
| var exposedHeaders: SkylarkNode = podSupportHeaders .+. | ||
| headers.toSkylark() .+. depHdrs.toSkylark() | ||
| headersWithoutPodSupport.toSkylark() .+. depHdrs.toSkylark() |
There was a problem hiding this comment.
I think another option here is to do something similar to what I'm doing, but just add the pod_support glob into the main headers.include glob. I don't know if glob itself will complain about globs that match the same thing more than once or if it'll de-dupe internally before passing the targets/files on to Bazel. Also not sure if that's a preferred solution even if it does work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some podspecs just include all files under their directory (eg RCTText). This breaks PodToBUILD both during generation (it passed an empty string to
fileManager.subpathsOfDirectory, which threw an error) and at runtime (it double included thepod_supportheaders, which caused Bazel to fail). This fixes both of those issues.