fix: Skip cxx_builtin_include_directories filtering when remote #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
force-pushed
the
skip-filtering-when-remote
branch
2 times, most recently
from
615c70f
to
00874b4
Compare
honnix
commented
Nov 7, 2024
honnix
force-pushed
the
skip-filtering-when-remote
branch
from
00874b4
to
660f9c6
Compare
fmeum
approved these changes
Nov 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to determine directory existence remotely, so for remote execution the best option is not to filter. This PR addresses https://github.com/bazel-contrib/toolchains_llvm/pull/280/files/1a11e9f0f58f89789b5cd0a389efc7e321e33b3b#r1830121103