Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test module for Bazel 8 #410

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix test module for Bazel 8 #410

merged 2 commits into from
Oct 31, 2024

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Oct 31, 2024

Clean up canonical label usages and fix runfiles references for --nolegacy_external_runfiles.

@fmeum
Copy link
Member Author

fmeum commented Oct 31, 2024

This is blocked on bazelbuild/bazel#24154.

@fmeum fmeum marked this pull request as draft October 31, 2024 09:59
Clean up canonical label usages and fix runfiles references for `--nolegacy_external_runfiles`.
@fmeum fmeum marked this pull request as ready for review October 31, 2024 10:19
@fmeum
Copy link
Member Author

fmeum commented Oct 31, 2024

We can merge the changes without enabling testing on Bazel 8 yet, so this is no longer blocked on 8.0.0rc3.

Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmeum fmeum merged commit 28be57c into master Oct 31, 2024
36 checks passed
@fmeum fmeum deleted the bazel-8 branch October 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants