-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WebAssembly target platforms wasm{32,64}-unknown-unknown
#405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me.
Could you add a test that builds a simple binary for wasm using a transition? Ideally that would also include adding a usage of libclang_rt
.
Tests added:
|
1e13068
to
c287c5e
Compare
Thanks for adding tests! CI is failing now though. |
CI appears to be failing for infrastructure reasons. I'll try poking at it a bit, but it might require a bit of refactoring to the test scripts. container_test (debian, true):
container_test (linux_sysroot, true)
test (macos-latest, latest, false)
|
Updated tests so that WebAssembly targets get their own directory, and the test script runs Also updated
|
More test updates:
|
e329a6d
to
a633424
Compare
401c187
to
ba7e71b
Compare
ba7e71b
to
6e11105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a great addition!
No description provided.