Fix support for --incompatible_disallow_empty_glob #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows downstream repos to set this flag
rrbutani
reviewed
May 21, 2024
There was a problem hiding this comment.
This change looks good but CI is failing on globs in deps (openssl): https://github.com/bazel-contrib/toolchains_llvm/actions/runs/9182559234/job/25251665225?pr=331#step:4:38
|
@keith would you mind adding toolchains_llvm/tests/openssl/openssl.bazel Lines 840 to 845 in be777a3 Or we can just remove |
|
added! we'll see! |
|
Ping on this, would be great to land it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows downstream repos to set this flag