Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rctx.read instead of cat to parse /etc/os-release #231

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Use rctx.read instead of cat to parse /etc/os-release #231

merged 1 commit into from
Oct 6, 2023

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Oct 6, 2023

Shorter code and avoids a dependency on system cat

@dzbarsky dzbarsky changed the title Use rctx.read instead of cat to parse lsb-release Use rctx.read instead of cat to parse /etc/os-release Oct 6, 2023
jsharpe
jsharpe approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsharpe jsharpe merged commit 0a9feb7 into bazel-contrib:master Oct 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @jsharpe