Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes plus support for Optimization.jl #50

Merged
merged 2 commits into from
Oct 23, 2024
Merged

API changes plus support for Optimization.jl #50

merged 2 commits into from
Oct 23, 2024

Conversation

oschulz
Copy link
Member

@oschulz oschulz commented Oct 20, 2024

No description provided.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 83.83838% with 16 lines in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (bcc996f) to head (34d2048).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/mgvi_impl.jl 75.67% 9 Missing ⚠️
src/residual_samplers.jl 81.81% 6 Missing ⚠️
ext/MGVIOptimizationExt.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   71.57%   71.84%   +0.27%     
==========================================
  Files           8       10       +2     
  Lines         292      341      +49     
==========================================
+ Hits          209      245      +36     
- Misses         83       96      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz force-pushed the optimization branch 2 times, most recently from 197988f to f59a58c Compare October 20, 2024 22:13
@oschulz oschulz merged commit 34d2048 into main Oct 23, 2024
11 checks passed
@oschulz oschulz deleted the optimization branch October 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants