Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log the missing bucket type name when returning {error, no_type} #819

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

joecaswell
Copy link

Adresses #815

Manual test:

% tail -n1 log/console.log
2016-02-29 13:17:51.096 [info] <0.445.0>@riak_kv_entropy_manager:perhaps_log_throttle_change:853 Changing AAE throttle from undefined -> 0 msec/key, based on maximum vnode mailbox size 1 from '[email protected]'

% bin/riak-admin bucket-type list
default (active)
goodtype (active)

% bin/riak attach
Remote Shell: Use "Ctrl-C a" to quit. q() or init:stop() will terminate the riak node.
Eshell V5.10.3  (abort with ^G)

([email protected])1> riak_kv_util:get_index_n({{<<"goodtype">>,<<"bucket">>},<<"key">>}).
{616571003248974668617179538802181898917346541568,4}

([email protected])2> riak_kv_util:get_index_n({{<<"badtype">>,<<"bucket">>},<<"key">>}). 
** exception error: no function clause matching proplists:get_value(n_val,{error,no_type},undefined) (proplists.erl, line 225)
     in function  riak_kv_util:get_index_n/1 (src/riak_kv_util.erl, line 190)

([email protected])3> 
^C%                                                                                                                                                                                                                                                        

% tail -n2 log/console.log     
2016-02-29 13:17:51.096 [info] <0.445.0>@riak_kv_entropy_manager:perhaps_log_throttle_change:853 Changing AAE throttle from undefined -> 0 msec/key, based on maximum vnode mailbox size 1 from '[email protected]'
2016-02-29 13:18:55.144 [error] <0.2626.0>@riak_core_bucket:get_bucket:124 {error,no_type} getting properties of bucket {<<"badtype">>,<<"bucket">>}

@bsparrow435
Copy link
Contributor

+1 ac92614

@bsparrow435
Copy link
Contributor

👍 ac92614

borshop added a commit that referenced this pull request Mar 14, 2016
log the missing bucket type name when returning {error, no_type}

Reviewed-by: bsparrow435,bsparrow435
@bsparrow435
Copy link
Contributor

@borshop merge

@borshop borshop merged commit ac92614 into 2.0 Mar 14, 2016
@martincox martincox deleted the jhc-log_no_type branch June 14, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants