Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Thumbs #338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Enable Thumbs #338

wants to merge 1 commit into from

Conversation

ooshlablu
Copy link

No description provided.

@ooshlablu
Copy link
Author

thumbot retry

@thumbot
Copy link

thumbot commented Dec 1, 2016

enable_thumbs c1dd5bb ➡️ develop 855f38e ✅ completed
Looks good! 👍
✅ MERGE

Started at: 2016-12-01 11:50
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 855f38e
Exit Code: OK

📄




Updating 855f38e..c1dd5bb
Fast-forward (no commit created; -m option ignored)
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml


✅ MAKE_CLEAN

Started at: 2016-12-01 11:50
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make clean

./rebar clean
==> develop.855f38e.enable_thumbs.c1dd5bb (clean)



✅ MAKE_DEPS

Started at: 2016-12-01 11:50
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make deps

./rebar get-deps
==> develop.855f38e.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling protobuffs from {git,"https://github.com/basho/erlang_protobuffs.git",
                             {tag,"0.9.0"}}
Cloning into 'protobuffs'...
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> protobuffs (get-deps)
Pulling meck from {git,"https://github.com/basho/meck.git",{tag,"0.8.2"}}
Cloning into 'meck'...
==> meck (get-deps)
==> hamcrest (get-deps)



✅ MAKE_COMPILE

Started at: 2016-12-01 11:50
Duration: 5 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make compile

./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.855f38e.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
Compiled src/meck_cover.erl
Compiled src/meck_expect.erl
Compiled src/meck_args_matcher.erl
Compiled src/meck_matcher.erl
Compiled src/meck_code_gen.erl
Compiled src/meck_history.erl
Compiled src/meck.erl
Compiled src/meck_code.erl
Compiled src/meck_util.erl
Compiled src/meck_ret_spec.erl
Compiled src/meck_proc.erl
==> protobuffs (pre_compile)
==> protobuffs (compile)
Compiled src/protobuffs_scanner.xrl
Compiled src/protobuffs_parser.yrl
Compiled src/protobuffs_cli.erl
Compiled src/pokemon_pb.erl
Compiled src/protobuffs.erl
Compiled src/protobuffs_file.erl
Compiled src/protobuffs_scanner.erl
Compiled src/protobuffs_parser.erl
Compiled src/protobuffs_compile.erl
==> hamcrest (pre_compile)
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
Generated src/riak_pb_messages.erl
==> riak_pb (compile)
Compiling src/riak_kv.proto

=INFO REPORT==== 1-Dec-2016::11:50:53 ===
Writing header file to "riak_kv_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:53 ===
Writing beam file to "riak_kv_pb.beam"
Compiling src/riak_dt.proto

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing header file to "riak_dt_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing beam file to "riak_dt_pb.beam"
Compiling src/riak_yokozuna.proto

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing header file to "riak_yokozuna_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing beam file to "riak_yokozuna_pb.beam"
Compiling src/riak_search.proto

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing header file to "riak_search_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing beam file to "riak_search_pb.beam"
Compiling src/riak.proto

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing header file to "riak_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing beam file to "riak_pb.beam"
Compiling src/riak_ts.proto

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing header file to "riak_ts_pb.hrl"

=INFO REPORT==== 1-Dec-2016::11:50:54 ===
Writing beam file to "riak_ts_pb.beam"
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_pb_dt_codec.erl
==> develop.855f38e.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl



✅ MAKE_TEST

Started at: 2016-12-01 11:50
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make test

./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.855f38e.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.855f38e.enable_thumbs.c1dd5bb (compile)

NOTICE: If Riak is running & listening to the default ProtocolBuffers
        port, then additional EUnit tests will run.
        Tests will _not_ run correctly if allow_mult=true.
        Also, it would be great to document here what other
        Riak configuration bits are prerequisites for running
        the integration test suite...........

./rebar eunit skip_deps=true
==> develop.855f38e.enable_thumbs.c1dd5bb (eunit)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_set.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_map.erl
Compiled src/riakc_counter.erl
Compiled test/riakc_test_utils.erl
Compiled test/riakc_utils_tests.erl
Compiled test/riakc_ts_tests.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl
Compiled test/riakc_pb_socket_tests.erl
======================== EUnit ========================
module 'riakc_counter'
module 'riakc_flag'
module 'riakc_ts_put_operator'
module 'riakc_ts_query_operator'
module 'riakc_utils'
  riakc_utils_tests: bad_unicode_binary_test (module 'riakc_utils_tests')...[0.005 s] ok
  [done in 0.008 s]
riakc_map: prop_nested_defaults_test (module 'riakc_map')...ok
module 'riakc_ts_get_operator'
module 'riakc_test_utils'
module 'riakc_ts'
  module 'riakc_ts_tests'
    [done in 0.050 s]
  [done in 0.108 s]
module 'riakc_datatype'
  riakc_datatype:118: datatypes_test_ ( prop_module_type() ).......................................................................................................
OK, passed 100 tests
[1.618 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).............................................................(x10).......(x1)..
Time limit reached: 2.0 seconds.

OK, passed 7272 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)............................................................(x10).(x1).......
Time limit reached: 2.0 seconds.

OK, passed 7117 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x10).(x1)....
Time limit reached: 2.0 seconds.

OK, passed 34114 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x10).........(x1)...
Time limit reached: 2.0 seconds.

OK, passed 29193 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).......(x10)....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 25845 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)..(x1)......
Time limit reached: 2.0 seconds.

OK, passed 1626 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_value_immutable(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..................................................(x10).(x1).....
Time limit reached: 2.0 seconds.

OK, passed 6115 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10).(x1)..
Time limit reached: 2.0 seconds.

OK, passed 8512 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 8663 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)................................................(x10)...(x1)........
Time limit reached: 2.0 seconds.

OK, passed 59138 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 34709 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).............................(x10).(x1)...
Time limit reached: 2.0 seconds.

OK, passed 40113 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)..(x1).........
Time limit reached: 2.0 seconds.

OK, passed 1729 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_unmodified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).............................................................................................(x10)..(x1)..
Time limit reached: 2.0 seconds.

OK, passed 10422 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................(x10)..(x1).....
Time limit reached: 2.0 seconds.

OK, passed 7025 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)............................................................(x10)..
Time limit reached: 2.0 seconds.

OK, passed 7120 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x10).......(x1).
Time limit reached: 2.0 seconds.

OK, passed 34171 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)....(x10).........(x1).
Time limit reached: 2.0 seconds.

OK, passed 29591 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............(x100).(x10)....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 26249 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)...(x10)........
Time limit reached: 2.0 seconds.

OK, passed 1480 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)................................................(x10).........(x1)...
Time limit reached: 2.0 seconds.

OK, passed 5993 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................(x10)........(x1)....
Time limit reached: 2.0 seconds.

OK, passed 8784 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8675 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............................................(x100).......(x1)........
Time limit reached: 2.0 seconds.

OK, passed 57808 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)...(x10).......(x1)..
Time limit reached: 2.0 seconds.

OK, passed 34472 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100)......(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 39737 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)....(x1)...
Time limit reached: 2.0 seconds.

OK, passed 1643 tests
[2.004 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................................(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 10163 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).....
Time limit reached: 2.0 seconds.

OK, passed 8650 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10).......(x1)....
Time limit reached: 2.0 seconds.

OK, passed 8474 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).....................................(x100)......(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 48763 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100).(x10)..(x1)......
Time limit reached: 2.0 seconds.

OK, passed 31226 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)...(x10)......(x1).
Time limit reached: 2.0 seconds.

OK, passed 34461 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)..(x1).
Time limit reached: 2.0 seconds.

OK, passed 1721 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................(x10).........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 9599 tests
[2.001 s] ok
  [done in 71.750 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.005 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.405.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29420.0>: Skipped - needs live server
    [done in 0.089 s]
  [done in 0.092 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb/.eunit/index.html



✅ MAKE_XREF

Started at: 2016-12-01 11:52
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make xref

./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.855f38e.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.855f38e.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.855f38e.enable_thumbs.c1dd5bb (xref)



✅ MAKE_DIALYZER

Started at: 2016-12-01 11:52
Duration: 22 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.855f38e.enable_thumbs.c1dd5bb; make dialyzer

./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.855f38e.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.855f38e.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Compiling some key modules to native code... done in 0m8.71s
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  beam_lib:chunks/2
  code:delete/1
  code:ensure_loaded/1
  code:get_object_code/1
  code:is_sticky/1
  code:load_binary/3
  code:purge/1
  code:stick_mod/1
  code:unstick_mod/1
  compile:forms/2
  cover:compile_beam/1
  cover:compile_beam/2
  cover:compile_module/2
  cover:export/2
  cover:get_term/1
  cover:import/1
  cover:is_compiled/1
  cover:module_info/1
  cover:write/2
  dict:erase/2
  dict:fetch/2
  dict:find/2
  dict:fold/3
  dict:from_list/1
  dict:is_key/2
  dict:new/0
  dict:size/1
  dict:store/3
  dict:to_list/1
  erl_parse:abstract/1
  erl_parse:parse_exprs/1
  erl_prettypr:format/1
  erl_scan:reserved_word/1
  erl_scan:string/1
  erl_scan:token_info/2
  erl_syntax:form_list/1
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:erase/1
  erlang:fun_info/2
  erlang:get/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:get_stacktrace/0
  erlang:integer_to_list/1
  erlang:iolist_size/1
  erlang:is_builtin/3
  erlang:is_process_alive/1
  erlang:link/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_existing_atom/1
  erlang:list_to_float/1
  erlang:list_to_integer/1
  erlang:list_to_tuple/1
  erlang:make_fun/3
  erlang:monitor/2
  erlang:process_flag/2
  erlang:put/2
  erlang:raise/3
  erlang:registered/0
  erlang:split_binary/2
  erlang:term_to_binary/1
  error_logger:error_report/1
  error_logger:info_msg/2
  error_logger:warning_msg/2
  error_logger:warning_report/1
  escript:script_name/0
  ets:match_spec_compile/1
  ets:match_spec_run/2
  eunit:test/1
  file:close/1
  file:delete/1
  file:open/2
  file:path_open/3
  file:write_file/2
  filename:basename/1
  filename:basename/2
  filename:extension/1
  filename:join/2
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  gen_server:call/2
  gen_server:call/3
  gen_server:reply/2
  gen_server:start/4
  io:format/2
  io:format/3
  io:request/2
  io_lib:deep_char_list/1
  io_lib:format/2
  io_lib:fread/2
  io_lib:write/1
  io_lib:write_char/1
  io_lib:write_string/1
  lists:duplicate/2
  lists:keytake/3
  lists:seq/2
  lists:sublist/2
  lists:sublist/3
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  os:timestamp/0
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  proplists:is_defined/2
  re:replace/4
  re:run/2
  re:split/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
  string:to_lower/1
  string:to_upper/1
  string:tokens/2
  unicode:characters_to_binary/1
Unknown types:
  erlang:timestamp/0
  ets:comp_match_spec/0
  meck_history:history_record/0
  proplists:property/0
 done in 0m1.77s
done (passed successfully)
==> develop.855f38e.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis... done in 0m3.07s
done (passed successfully)



⬜ 0 of 2 Code reviews from organization basho

@davidx
Copy link

davidx commented Dec 1, 2016

+1

@thumbot
Copy link

thumbot commented Dec 6, 2016

enable_thumbs c1dd5bb ➡️ develop dcc9b8d ✅ completed
Looks good! 👍
✅ MERGE

Started at: 2016-12-06 08:52
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop dcc9b8d
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2016-12-06 08:52
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2016-12-06 08:53
Duration: 5 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.2.0.2"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling protobuffs from {git,"https://github.com/basho/erlang_protobuffs.git",
                             {tag,"0.9.0"}}
Cloning into 'protobuffs'...
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> protobuffs (get-deps)
Pulling meck from {git,"https://github.com/basho/meck.git",{tag,"0.8.2"}}
Cloning into 'meck'...
==> meck (get-deps)
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2016-12-06 08:53
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
Compiled src/meck_cover.erl
Compiled src/meck_expect.erl
Compiled src/meck_matcher.erl
Compiled src/meck_args_matcher.erl
Compiled src/meck_code_gen.erl
Compiled src/meck_history.erl
Compiled src/meck.erl
Compiled src/meck_code.erl
Compiled src/meck_util.erl
Compiled src/meck_ret_spec.erl
Compiled src/meck_proc.erl
==> protobuffs (pre_compile)
==> protobuffs (compile)
Compiled src/protobuffs_scanner.xrl
Compiled src/protobuffs_parser.yrl
Compiled src/protobuffs_cli.erl
Compiled src/protobuffs.erl
Compiled src/pokemon_pb.erl
Compiled src/protobuffs_file.erl
Compiled src/protobuffs_scanner.erl
Compiled src/protobuffs_parser.erl
Compiled src/protobuffs_compile.erl
==> hamcrest (pre_compile)
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
Generated src/riak_pb_messages.erl
==> riak_pb (compile)
Compiling src/riak_kv.proto

=INFO REPORT==== 6-Dec-2016::08:53:08 ===
Writing header file to "riak_kv_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:08 ===
Writing beam file to "riak_kv_pb.beam"
Compiling src/riak_dt.proto

=INFO REPORT==== 6-Dec-2016::08:53:08 ===
Writing header file to "riak_dt_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing beam file to "riak_dt_pb.beam"
Compiling src/riak_yokozuna.proto

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing header file to "riak_yokozuna_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing beam file to "riak_yokozuna_pb.beam"
Compiling src/riak_search.proto

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing header file to "riak_search_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing beam file to "riak_search_pb.beam"
Compiling src/riak.proto

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing header file to "riak_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing beam file to "riak_pb.beam"
Compiling src/riak_ts.proto

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing header file to "riak_ts_pb.hrl"

=INFO REPORT==== 6-Dec-2016::08:53:09 ===
Writing beam file to "riak_ts_pb.beam"
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_pb_dt_codec.erl
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2016-12-06 08:53
Duration: 80 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 151 lines ...
........................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)......(x10)...(x1).........
Time limit reached: 2.0 seconds.

OK, passed 29739 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).........(x10).......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 26073 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....(x10).........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 1592 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).................................................(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 6063 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................
Time limit reached: 2.0 seconds.

OK, passed 8400 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10).....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8555 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............................................(x100).(x10)..(x1)........
Time limit reached: 2.0 seconds.

OK, passed 58228 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)......(x10).........(x1).
Time limit reached: 2.0 seconds.

OK, passed 34791 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100).........(x10).....(x1)........
Time limit reached: 2.0 seconds.

OK, passed 40058 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).........
Time limit reached: 2.0 seconds.

OK, passed 1790 tests
[2.005 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................................(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 10046 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10).(x1)...
Time limit reached: 2.0 seconds.

OK, passed 8313 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................(x10)....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8249 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100).(x10)......(x1).......
Time limit reached: 2.0 seconds.

OK, passed 49267 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...................(x100).........(x10).(x1).
Time limit reached: 2.0 seconds.

OK, passed 31011 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)........(x10).(x1)..
Time limit reached: 2.0 seconds.

OK, passed 34912 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)..
Time limit reached: 2.0 seconds.

OK, passed 1620 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).....................................................................................(x10)...(x1)......
Time limit reached: 2.0 seconds.

OK, passed 9636 tests
[2.000 s] ok
  [done in 71.669 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...[0.001 s] ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.005 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.405.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29416.0>: Skipped - needs live server
    [done in 0.090 s]
  [done in 0.093 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2016-12-06 08:54
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (xref)





✅ MAKE_DIALYZER

Started at: 2016-12-06 08:54
Duration: 22 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.dcc9b8d.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Compiling some key modules to native code... done in 0m8.45s
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  beam_lib:chunks/2
  code:delete/1
  code:ensure_loaded/1
  code:get_object_code/1
  code:is_sticky/1
  code:load_binary/3
  code:purge/1
  code:stick_mod/1
  code:unstick_mod/1
  compile:forms/2
  cover:compile_beam/1
  cover:compile_beam/2
  cover:compile_module/2
  cover:export/2
  cover:get_term/1
  cover:import/1
  cover:is_compiled/1
  cover:module_info/1
  cover:write/2
  dict:erase/2
  dict:fetch/2
  dict:find/2
  dict:fold/3
  dict:from_list/1
  dict:is_key/2
  dict:new/0
  dict:size/1
  dict:store/3
  dict:to_list/1
  erl_parse:abstract/1
  erl_parse:parse_exprs/1
  erl_prettypr:format/1
  erl_scan:reserved_word/1
  erl_scan:string/1
  erl_scan:token_info/2
  erl_syntax:form_list/1
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:erase/1
  erlang:fun_info/2
  erlang:get/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:get_stacktrace/0
  erlang:integer_to_list/1
  erlang:iolist_size/1
  erlang:is_builtin/3
  erlang:is_process_alive/1
  erlang:link/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_existing_atom/1
  erlang:list_to_float/1
  erlang:list_to_integer/1
  erlang:list_to_tuple/1
  erlang:make_fun/3
  erlang:monitor/2
  erlang:process_flag/2
  erlang:put/2
  erlang:raise/3
  erlang:registered/0
  erlang:split_binary/2
  erlang:term_to_binary/1
  error_logger:error_report/1
  error_logger:info_msg/2
  error_logger:warning_msg/2
  error_logger:warning_report/1
  escript:script_name/0
  ets:match_spec_compile/1
  ets:match_spec_run/2
  eunit:test/1
  file:close/1
  file:delete/1
  file:open/2
  file:path_open/3
  file:write_file/2
  filename:basename/1
  filename:basename/2
  filename:extension/1
  filename:join/2
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  gen_server:call/2
  gen_server:call/3
  gen_server:reply/2
  gen_server:start/4
  io:format/2
  io:format/3
  io:request/2
  io_lib:deep_char_list/1
  io_lib:format/2
  io_lib:fread/2
  io_lib:write/1
  io_lib:write_char/1
  io_lib:write_string/1
  lists:duplicate/2
  lists:keytake/3
  lists:seq/2
  lists:sublist/2
  lists:sublist/3
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  os:timestamp/0
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  proplists:is_defined/2
  re:replace/4
  re:run/2
  re:split/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
  string:to_lower/1
  string:to_upper/1
  string:tokens/2
  unicode:characters_to_binary/1
Unknown types:
  erlang:timestamp/0
  ets:comp_match_spec/0
  meck_history:history_record/0
  proplists:property/0
 done in 0m1.79s
done (passed successfully)
==> develop.dcc9b8d.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis... done in 0m3.15s
done (passed successfully)





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Dec 6, 2016

enable_thumbs c1dd5bb ➡️ develop 736ad33 ✅ completed
Looks good! 👍
✅ MERGE

Started at: 2016-12-06 09:00
Duration: 3 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 736ad33
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2016-12-06 09:00
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.736ad33.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2016-12-06 09:00
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.736ad33.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.2.0.2"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling protobuffs from {git,"https://github.com/basho/erlang_protobuffs.git",
                             {tag,"0.9.0"}}
Cloning into 'protobuffs'...
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> protobuffs (get-deps)
Pulling meck from {git,"https://github.com/basho/meck.git",{tag,"0.8.2"}}
Cloning into 'meck'...
==> meck (get-deps)
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2016-12-06 09:00
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.736ad33.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
Compiled src/meck_cover.erl
Compiled src/meck_expect.erl
Compiled src/meck_matcher.erl
Compiled src/meck_args_matcher.erl
Compiled src/meck_code_gen.erl
Compiled src/meck_history.erl
Compiled src/meck.erl
Compiled src/meck_code.erl
Compiled src/meck_util.erl
Compiled src/meck_ret_spec.erl
Compiled src/meck_proc.erl
==> protobuffs (pre_compile)
==> protobuffs (compile)
Compiled src/protobuffs_scanner.xrl
Compiled src/protobuffs_parser.yrl
Compiled src/protobuffs_cli.erl
Compiled src/pokemon_pb.erl
Compiled src/protobuffs.erl
Compiled src/protobuffs_file.erl
Compiled src/protobuffs_scanner.erl
Compiled src/protobuffs_parser.erl
Compiled src/protobuffs_compile.erl
==> hamcrest (pre_compile)
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
Generated src/riak_pb_messages.erl
==> riak_pb (compile)
Compiling src/riak_kv.proto

=INFO REPORT==== 6-Dec-2016::09:00:18 ===
Writing header file to "riak_kv_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing beam file to "riak_kv_pb.beam"
Compiling src/riak_dt.proto

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing header file to "riak_dt_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing beam file to "riak_dt_pb.beam"
Compiling src/riak_yokozuna.proto

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing header file to "riak_yokozuna_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing beam file to "riak_yokozuna_pb.beam"
Compiling src/riak_search.proto

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing header file to "riak_search_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing beam file to "riak_search_pb.beam"
Compiling src/riak.proto

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing header file to "riak_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing beam file to "riak_pb.beam"
Compiling src/riak_ts.proto

=INFO REPORT==== 6-Dec-2016::09:00:19 ===
Writing header file to "riak_ts_pb.hrl"

=INFO REPORT==== 6-Dec-2016::09:00:20 ===
Writing beam file to "riak_ts_pb.beam"
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_pb_dt_codec.erl
==> develop.736ad33.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2016-12-06 09:00
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 151 lines ...
.........................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)........(x10)...(x1)....
Time limit reached: 2.0 seconds.

OK, passed 29934 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............(x10)......
Time limit reached: 2.0 seconds.

OK, passed 26160 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)...(x10).......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 1473 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)................................................(x10)....(x1).
Time limit reached: 2.0 seconds.

OK, passed 5941 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).........
Time limit reached: 2.0 seconds.

OK, passed 8690 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..............................................................................(x10).......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8975 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)................................................(x100).....(x10)...(x1).
Time limit reached: 2.0 seconds.

OK, passed 59631 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).........(x10)......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 35065 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100)....(x10).........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 39598 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)..(x1).
Time limit reached: 2.0 seconds.

OK, passed 1721 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................................(x10)...(x1)........
Time limit reached: 2.0 seconds.

OK, passed 10338 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8609 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10)....(x1)..
Time limit reached: 2.0 seconds.

OK, passed 8642 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100)......(x10).....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 49756 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100)...(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 31446 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).........(x10).(x1).....
Time limit reached: 2.0 seconds.

OK, passed 35015 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).......(x10).........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 1892 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).....................................................................................(x10).........
Time limit reached: 2.0 seconds.

OK, passed 9690 tests
[2.000 s] ok
  [done in 71.088 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...[0.001 s] ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.005 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.405.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29445.0>: Skipped - needs live server
    [done in 0.090 s]
  [done in 0.093 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2016-12-06 09:01
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.736ad33.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.736ad33.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.736ad33.enable_thumbs.c1dd5bb (xref)





✅ MAKE_DIALYZER

Started at: 2016-12-06 09:01
Duration: 22 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.736ad33.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> meck (get-deps)
==> protobuffs (get-deps)
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.736ad33.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> meck (pre_compile)
==> meck (compile)
==> protobuffs (pre_compile)
==> protobuffs (compile)
==> hamcrest (pre_compile)
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (pre_compile)
==> riak_pb (compile)
==> develop.736ad33.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Compiling some key modules to native code... done in 0m8.63s
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  beam_lib:chunks/2
  code:delete/1
  code:ensure_loaded/1
  code:get_object_code/1
  code:is_sticky/1
  code:load_binary/3
  code:purge/1
  code:stick_mod/1
  code:unstick_mod/1
  compile:forms/2
  cover:compile_beam/1
  cover:compile_beam/2
  cover:compile_module/2
  cover:export/2
  cover:get_term/1
  cover:import/1
  cover:is_compiled/1
  cover:module_info/1
  cover:write/2
  dict:erase/2
  dict:fetch/2
  dict:find/2
  dict:fold/3
  dict:from_list/1
  dict:is_key/2
  dict:new/0
  dict:size/1
  dict:store/3
  dict:to_list/1
  erl_parse:abstract/1
  erl_parse:parse_exprs/1
  erl_prettypr:format/1
  erl_scan:reserved_word/1
  erl_scan:string/1
  erl_scan:token_info/2
  erl_syntax:form_list/1
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:erase/1
  erlang:fun_info/2
  erlang:get/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:get_stacktrace/0
  erlang:integer_to_list/1
  erlang:iolist_size/1
  erlang:is_builtin/3
  erlang:is_process_alive/1
  erlang:link/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_existing_atom/1
  erlang:list_to_float/1
  erlang:list_to_integer/1
  erlang:list_to_tuple/1
  erlang:make_fun/3
  erlang:monitor/2
  erlang:process_flag/2
  erlang:put/2
  erlang:raise/3
  erlang:registered/0
  erlang:split_binary/2
  erlang:term_to_binary/1
  error_logger:error_report/1
  error_logger:info_msg/2
  error_logger:warning_msg/2
  error_logger:warning_report/1
  escript:script_name/0
  ets:match_spec_compile/1
  ets:match_spec_run/2
  eunit:test/1
  file:close/1
  file:delete/1
  file:open/2
  file:path_open/3
  file:write_file/2
  filename:basename/1
  filename:basename/2
  filename:extension/1
  filename:join/2
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  gen_server:call/2
  gen_server:call/3
  gen_server:reply/2
  gen_server:start/4
  io:format/2
  io:format/3
  io:request/2
  io_lib:deep_char_list/1
  io_lib:format/2
  io_lib:fread/2
  io_lib:write/1
  io_lib:write_char/1
  io_lib:write_string/1
  lists:duplicate/2
  lists:keytake/3
  lists:seq/2
  lists:sublist/2
  lists:sublist/3
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  os:timestamp/0
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  proplists:is_defined/2
  re:replace/4
  re:run/2
  re:split/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
  string:to_lower/1
  string:to_upper/1
  string:tokens/2
  unicode:characters_to_binary/1
Unknown types:
  erlang:timestamp/0
  ets:comp_match_spec/0
  meck_history:history_record/0
  proplists:property/0
 done in 0m1.70s
done (passed successfully)
==> develop.736ad33.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis... done in 0m3.21s
done (passed successfully)





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Dec 8, 2016

enable_thumbs c1dd5bb ➡️ develop c203271 ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2016-12-08 12:29
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop c203271
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2016-12-08 12:29
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.c203271.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2016-12-08 12:29
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.c203271.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2016-12-08 12:29
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.c203271.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_pb.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.c203271.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_map.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2016-12-08 12:29
Duration: 78 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).................(x100).......(x10).(x1)....
Time limit reached: 2.0 seconds.

OK, passed 28814 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........
Time limit reached: 2.0 seconds.

OK, passed 25900 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....(x10)........
Time limit reached: 2.0 seconds.

OK, passed 1580 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..............................................(x10)........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 5789 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8365 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)........(x1)......
Time limit reached: 2.0 seconds.

OK, passed 8386 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............................................(x100)......(x10).(x1)...
Time limit reached: 2.0 seconds.

OK, passed 57713 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).....(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 34637 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100).....(x10)......(x1).......
Time limit reached: 2.0 seconds.

OK, passed 39667 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)...(x10).........
Time limit reached: 2.0 seconds.

OK, passed 1490 tests
[2.007 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................................(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 9863 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................(x10).
Time limit reached: 2.0 seconds.

OK, passed 8210 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 7937 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).....................................(x100)......(x10)...(x1)....
Time limit reached: 2.0 seconds.

OK, passed 48734 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...................(x100)........(x10).......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 30979 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)......(x10).(x1).....
Time limit reached: 2.0 seconds.

OK, passed 34715 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....
Time limit reached: 2.0 seconds.

OK, passed 1500 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)...................................................................................(x10)..
Time limit reached: 2.0 seconds.

OK, passed 9420 tests
[2.000 s] ok
  [done in 71.104 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29232.0>: Skipped - needs live server
    [done in 0.088 s]
  [done in 0.091 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2016-12-08 12:30
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.c203271.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.c203271.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.c203271.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2016-12-08 12:30
Duration: 74 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.c203271.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.c203271.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.c203271.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m58.60s
done (passed successfully)
==> develop.c203271.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1717: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1759: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1827: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1849: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1865: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1996: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2241: Function start_auth/1 has no local return
riakc_pb_socket.erl:2242: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m4.14s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Dec 17, 2016

enable_thumbs c1dd5bb ➡️ develop decefaa ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2016-12-16 16:34
Duration: 0 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop decefaa
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2016-12-16 16:34
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.decefaa.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2016-12-16 16:34
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.decefaa.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2016-12-16 16:34
Duration: 7 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.decefaa.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.decefaa.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2016-12-16 16:35
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
...................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............(x100).........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 24002 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).........(x10)...(x1)......
Time limit reached: 2.0 seconds.

OK, passed 26036 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)...(x10).....(x1).
Time limit reached: 2.0 seconds.

OK, passed 1451 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)................................................(x10)........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 5982 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10)..(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8528 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................(x10).....(x1)...
Time limit reached: 2.0 seconds.

OK, passed 8753 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)................................................(x100)....(x10)..(x1)........
Time limit reached: 2.0 seconds.

OK, passed 59528 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)........................(x10)..(x1)......
Time limit reached: 2.0 seconds.

OK, passed 35126 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100).......(x10)...(x1)....
Time limit reached: 2.0 seconds.

OK, passed 39834 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10).....
Time limit reached: 2.0 seconds.

OK, passed 1650 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).............................................................................................(x10).....(x1)........
Time limit reached: 2.0 seconds.

OK, passed 10458 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10).......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8375 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 8546 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100)...(x1).
Time limit reached: 2.0 seconds.

OK, passed 49401 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100)..(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 31337 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)........................(x1).......
Time limit reached: 2.0 seconds.

OK, passed 35107 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).....
Time limit reached: 2.0 seconds.

OK, passed 1750 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................................(x10)..(x1).......
Time limit reached: 2.0 seconds.

OK, passed 9827 tests
[2.001 s] ok
  [done in 71.101 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29314.0>: Skipped - needs live server
    [done in 0.088 s]
  [done in 0.091 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2016-12-16 16:36
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.decefaa.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.decefaa.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.decefaa.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2016-12-16 16:36
Duration: 69 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.decefaa.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.decefaa.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.decefaa.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m55.37s
done (passed successfully)
==> develop.decefaa.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1717: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1759: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1827: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1849: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1865: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1996: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2241: Function start_auth/1 has no local return
riakc_pb_socket.erl:2242: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.83s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Dec 17, 2016

enable_thumbs c1dd5bb ➡️ develop 262e9ad ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2016-12-16 16:39
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 262e9ad
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2016-12-16 16:39
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.262e9ad.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2016-12-16 16:39
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.262e9ad.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2016-12-16 16:39
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.262e9ad.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_pb.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.262e9ad.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2016-12-16 16:39
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
..............................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)..(x10).......(x1)......
Time limit reached: 2.0 seconds.

OK, passed 29376 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 26137 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....(x10).........(x1).
Time limit reached: 2.0 seconds.

OK, passed 1591 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)................................................(x10)....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 5945 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 8656 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................(x10).......(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8777 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............................................(x100)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 58506 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).........(x10).........(x1).
Time limit reached: 2.0 seconds.

OK, passed 35091 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100).........(x10)......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 40069 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 1788 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................................(x10)..(x1)...
Time limit reached: 2.0 seconds.

OK, passed 10123 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x1)......
Time limit reached: 2.0 seconds.

OK, passed 8306 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8387 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100)...(x10)........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 49487 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x10).........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 31192 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).........(x10)......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 35065 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 1646 tests
[2.006 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................................(x10).......(x1).
Time limit reached: 2.0 seconds.

OK, passed 9871 tests
[2.001 s] ok
  [done in 71.094 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29488.0>: Skipped - needs live server
    [done in 0.088 s]
  [done in 0.091 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2016-12-16 16:40
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.262e9ad.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.262e9ad.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.262e9ad.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2016-12-16 16:40
Duration: 67 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.262e9ad.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.262e9ad.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.262e9ad.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m53.60s
done (passed successfully)
==> develop.262e9ad.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1717: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1759: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1827: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1849: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1865: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1996: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2241: Function start_auth/1 has no local return
riakc_pb_socket.erl:2242: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.82s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Jan 10, 2017

enable_thumbs c1dd5bb ➡️ develop d5d4150 ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-01-10 13:05
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop d5d4150
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-01-10 13:05
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.d5d4150.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-01-10 13:05
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.d5d4150.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-01-10 13:05
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.d5d4150.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.d5d4150.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-01-10 13:05
Duration: 80 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
............................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100).....(x10).(x1)......
Time limit reached: 2.0 seconds.

OK, passed 29616 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).........(x10).(x1).......
Time limit reached: 2.0 seconds.

OK, passed 26017 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 1789 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)................................................(x10).........
Time limit reached: 2.0 seconds.

OK, passed 5990 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8697 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10)..
Time limit reached: 2.0 seconds.

OK, passed 8420 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)................................................(x100).(x10)..(x1).
Time limit reached: 2.0 seconds.

OK, passed 59221 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).......(x10).....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 34855 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100)...(x10)...(x1).....
Time limit reached: 2.0 seconds.

OK, passed 39435 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)...(x1).........
Time limit reached: 2.0 seconds.

OK, passed 1639 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................................(x10).....
Time limit reached: 2.0 seconds.

OK, passed 10150 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10).......(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8378 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10).......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8479 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100)..(x10).....(x1).
Time limit reached: 2.0 seconds.

OK, passed 49351 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100)....(x1)..
Time limit reached: 2.0 seconds.

OK, passed 31502 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)........(x10).......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 34973 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).......
Time limit reached: 2.0 seconds.

OK, passed 1770 tests
[2.004 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................(x10)........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 9589 tests
[2.001 s] ok
  [done in 72.207 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.022 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...[0.001 s] ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29313.0>: Skipped - needs live server
    [done in 0.089 s]
  [done in 0.092 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-01-10 13:07
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.d5d4150.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.d5d4150.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.d5d4150.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-01-10 13:07
Duration: 74 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.d5d4150.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.d5d4150.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.d5d4150.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m59.86s
done (passed successfully)
==> develop.d5d4150.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1717: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1759: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1827: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1849: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1865: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1996: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2241: Function start_auth/1 has no local return
riakc_pb_socket.erl:2242: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m4.03s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Jan 18, 2017

enable_thumbs c1dd5bb ➡️ develop 09beedf ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-01-18 12:17
Duration: 0 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 09beedf
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-01-18 12:17
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.09beedf.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-01-18 12:17
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.09beedf.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-01-18 12:17
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.09beedf.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.09beedf.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-01-18 12:17
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
ed(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)...(x10)......(x1)......
Time limit reached: 2.0 seconds.

OK, passed 29466 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........(x10)....
Time limit reached: 2.0 seconds.

OK, passed 25940 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....(x10).......
Time limit reached: 2.0 seconds.

OK, passed 1570 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)...............................................(x1)...
Time limit reached: 2.0 seconds.

OK, passed 5803 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10)..
Time limit reached: 2.0 seconds.

OK, passed 8520 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10)....(x1)...
Time limit reached: 2.0 seconds.

OK, passed 8543 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............................................(x100)....(x10)....(x1)....
Time limit reached: 2.0 seconds.

OK, passed 58544 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)........................(x10).......(x1).
Time limit reached: 2.0 seconds.

OK, passed 35171 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100).........(x10).(x1)......
Time limit reached: 2.0 seconds.

OK, passed 40016 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 1646 tests
[2.004 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................................(x10)..(x1).......
Time limit reached: 2.0 seconds.

OK, passed 10027 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10).........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8397 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8389 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100).(x10).........
Time limit reached: 2.0 seconds.

OK, passed 49290 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............(x100)..(x10).......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 26379 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........
Time limit reached: 2.0 seconds.

OK, passed 25900 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10).(x1)..
Time limit reached: 2.0 seconds.

OK, passed 1612 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................(x10)......(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8768 tests
[2.000 s] ok
  [done in 71.777 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29259.0>: Skipped - needs live server
    [done in 0.587 s]
  [done in 0.590 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-01-18 12:19
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.09beedf.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.09beedf.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.09beedf.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-01-18 12:19
Duration: 70 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.09beedf.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.09beedf.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.09beedf.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m55.55s
done (passed successfully)
==> develop.09beedf.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1714: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1756: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1824: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1846: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1862: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1993: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2238: Function start_auth/1 has no local return
riakc_pb_socket.erl:2239: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.76s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Jan 21, 2017

enable_thumbs c1dd5bb ➡️ develop 9978a3d ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-01-20 18:31
Duration: 0 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 9978a3d
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-01-20 18:31
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.9978a3d.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-01-20 18:31
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.9978a3d.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",
                          {branch,"develop"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-01-20 18:31
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.9978a3d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.9978a3d.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-01-20 18:32
Duration: 79 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
............................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............(x100)......(x10)......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 26765 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..........(x100).....(x10)........(x1)......
Time limit reached: 2.0 seconds.

OK, passed 21686 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)..(x1)......
Time limit reached: 2.0 seconds.

OK, passed 1626 tests
[2.004 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).............................................(x10)........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 5688 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).....................................................................(x10)......(x1)..
Time limit reached: 2.0 seconds.

OK, passed 8062 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).....................................................................(x10).(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8019 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...........................(x100)......(x10).(x1).........
Time limit reached: 2.0 seconds.

OK, passed 38719 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).......(x10).....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 25855 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).........................(x100)...(x10)......(x1)......
Time limit reached: 2.0 seconds.

OK, passed 36466 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 1769 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................................(x10)........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 10287 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8387 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10).....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 8359 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x10)........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 49189 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100).(x10)....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 31249 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)........(x10)........(x1).....
Time limit reached: 2.0 seconds.

OK, passed 34985 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).......(x10)......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 1865 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).....................................................................................(x10).......(x1)......
Time limit reached: 2.0 seconds.

OK, passed 9676 tests
[2.000 s] ok
  [done in 71.700 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.006 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...[0.001 s] ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29479.0>: Skipped - needs live server
    [done in 0.592 s]
  [done in 0.595 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-01-20 18:33
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.9978a3d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.9978a3d.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.9978a3d.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-01-20 18:33
Duration: 70 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.9978a3d.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.9978a3d.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.9978a3d.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m55.05s
done (passed successfully)
==> develop.9978a3d.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1714: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1756: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1824: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1846: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1862: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1993: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2238: Function start_auth/1 has no local return
riakc_pb_socket.erl:2239: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.81s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Feb 1, 2017

enable_thumbs c1dd5bb ➡️ develop f3e6401 ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-02-01 14:48
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop f3e6401
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-02-01 14:48
Duration: 0 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.f3e6401.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-02-01 14:48
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.f3e6401.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.3.0.0"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-02-01 14:48
Duration: 7 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.f3e6401.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.f3e6401.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-02-01 14:48
Duration: 80 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
........................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)........(x10).(x1)........
Time limit reached: 2.0 seconds.

OK, passed 29918 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........(x10)...(x1)......
Time limit reached: 2.0 seconds.

OK, passed 25936 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)..(x10)........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 1382 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).............................................(x1)........
Time limit reached: 2.0 seconds.

OK, passed 5608 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................(x10)...
Time limit reached: 2.0 seconds.

OK, passed 7930 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..................................................................(x10).........(x1)......
Time limit reached: 2.0 seconds.

OK, passed 7796 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..........................(x100).........(x10).....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 38059 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100).........(x10)....(x1).........
Time limit reached: 2.0 seconds.

OK, passed 26049 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100)..(x10).......(x1).
Time limit reached: 2.0 seconds.

OK, passed 29371 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)....(x10).........(x1)...
Time limit reached: 2.0 seconds.

OK, passed 1593 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).............................................................................................(x10).........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 10498 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10)......(x1).......
Time limit reached: 2.0 seconds.

OK, passed 8467 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x1).
Time limit reached: 2.0 seconds.

OK, passed 8301 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).....................................(x100)........(x10)...(x1).......
Time limit reached: 2.0 seconds.

OK, passed 48937 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...................(x100).........(x10).......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 31073 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100).........(x10)..(x1)......
Time limit reached: 2.0 seconds.

OK, passed 35026 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10)....(x1).
Time limit reached: 2.0 seconds.

OK, passed 1741 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)......................................................................................(x1)......
Time limit reached: 2.0 seconds.

OK, passed 9706 tests
[2.001 s] ok
  [done in 71.695 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.005 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1418:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1418:<0.29471.0>: Skipped - needs live server
    [done in 0.589 s]
  [done in 0.592 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-02-01 14:49
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.f3e6401.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.f3e6401.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.f3e6401.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-02-01 14:49
Duration: 71 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.f3e6401.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.f3e6401.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.f3e6401.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m57.44s
done (passed successfully)
==> develop.f3e6401.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1714: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1756: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1824: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1846: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1862: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1993: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2238: Function start_auth/1 has no local return
riakc_pb_socket.erl:2239: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.76s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Feb 3, 2017

enable_thumbs c1dd5bb ➡️ develop 82ae32b ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-02-03 14:42
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 82ae32b
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-02-03 14:42
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.82ae32b.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-02-03 14:42
Duration: 2 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.82ae32b.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.3.0.0"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-02-03 14:42
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.82ae32b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_pb.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.82ae32b.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_map.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-02-03 14:42
Duration: 80 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 143 lines ...
.................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..................(x100).....(x10).........(x1).
Time limit reached: 2.0 seconds.

OK, passed 29691 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........(x10)..(x1)...
Time limit reached: 2.0 seconds.

OK, passed 25923 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)....
Time limit reached: 2.0 seconds.

OK, passed 1640 tests
[2.004 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)...............................................(x10)........(x1)..
Time limit reached: 2.0 seconds.

OK, passed 5882 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10)..(x1).
Time limit reached: 2.0 seconds.

OK, passed 8521 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10)...(x1).
Time limit reached: 2.0 seconds.

OK, passed 8631 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............................................(x100)....(x10).......(x1)..
Time limit reached: 2.0 seconds.

OK, passed 58572 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)......(x1).
Time limit reached: 2.0 seconds.

OK, passed 34701 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100)...(x10)........(x1).......
Time limit reached: 2.0 seconds.

OK, passed 39487 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).......(x1).
Time limit reached: 2.0 seconds.

OK, passed 1771 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)............................................................................................(x10).(x1)........
Time limit reached: 2.0 seconds.

OK, passed 10318 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10)....
Time limit reached: 2.0 seconds.

OK, passed 8440 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................(x10).....(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8558 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100)..(x10).........
Time limit reached: 2.0 seconds.

OK, passed 49390 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100)..(x10).(x1).
Time limit reached: 2.0 seconds.

OK, passed 31311 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)........(x10)...(x1)....
Time limit reached: 2.0 seconds.

OK, passed 34934 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)....(x1)..
Time limit reached: 2.0 seconds.

OK, passed 1642 tests
[2.005 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).......................................................................................(x1).....
Time limit reached: 2.0 seconds.

OK, passed 9805 tests
[2.001 s] ok
  [done in 71.655 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: bad_connect_test...ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.004 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1463:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1463:<0.29299.0>: Skipped - needs live server
    [done in 0.588 s]
  [done in 0.591 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 64 tests passed.
Cover analysis: /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-02-03 14:43
Duration: 4 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.82ae32b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.82ae32b.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.82ae32b.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-02-03 14:43
Duration: 69 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.82ae32b.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.82ae32b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.82ae32b.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m55.33s
done (passed successfully)
==> develop.82ae32b.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1714: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1756: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1824: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1846: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1862: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1993: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2238: Function start_auth/1 has no local return
riakc_pb_socket.erl:2239: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.73s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Feb 14, 2017

enable_thumbs c1dd5bb ➡️ develop 8ae580b ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-02-14 14:06
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 8ae580b
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-02-14 14:06
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.8ae580b.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-02-14 14:06
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.8ae580b.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.3.0.0"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-02-14 14:06
Duration: 6 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.8ae580b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.8ae580b.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-02-14 14:07
Duration: 80 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 144 lines ...
......................................................................................(x1000)..................(x100)....(x10)...(x1).........
Time limit reached: 2.0 seconds.

OK, passed 29539 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)..............(x100)........(x10)...(x1)........
Time limit reached: 2.0 seconds.

OK, passed 25938 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)...(x10).........
Time limit reached: 2.0 seconds.

OK, passed 1490 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)...............................................(x10)...(x1)......
Time limit reached: 2.0 seconds.

OK, passed 5836 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).....(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8655 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)...........................................................................(x10).(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8618 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...............................................(x100).....(x10)........(x1).....
Time limit reached: 2.0 seconds.

OK, passed 58685 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)......(x10)........(x1)......
Time limit reached: 2.0 seconds.

OK, passed 34786 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................(x100)......(x10).......(x1).....
Time limit reached: 2.0 seconds.

OK, passed 39775 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).........(x1).........
Time limit reached: 2.0 seconds.

OK, passed 1799 tests
[2.003 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..........................................................................................(x10)......(x1).........
Time limit reached: 2.0 seconds.

OK, passed 10169 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8388 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)......(x1)........
Time limit reached: 2.0 seconds.

OK, passed 8368 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)......................................(x100).(x10).......(x1)..
Time limit reached: 2.0 seconds.

OK, passed 49272 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)....................(x100).(x10).(x1).........
Time limit reached: 2.0 seconds.

OK, passed 31219 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)...(x10).....(x1)...
Time limit reached: 2.0 seconds.

OK, passed 34453 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100)......(x10).....(x1)....
Time limit reached: 2.0 seconds.

OK, passed 1754 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 9563 tests
[2.001 s] ok
  [done in 71.688 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...ok
  riakc_obj: secondary_index_utilities_test...ok
  [done in 0.054 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: listing_is_blocked_test...ok
    riakc_pb_socket_tests: mapred_over_bucket_is_blocked_test...ok
    riakc_pb_socket_tests: bad_connect_test...[0.001 s] ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.005 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1488:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1488:<0.29590.0>: Skipped - needs live server
    [done in 0.597 s]
  [done in 0.600 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 67 tests passed.
Cover analysis: /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-02-14 14:08
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.8ae580b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.8ae580b.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.8ae580b.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-02-14 14:08
Duration: 68 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.8ae580b.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.8ae580b.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.8ae580b.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m54.32s
done (passed successfully)
==> develop.8ae580b.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1746: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1788: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1856: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1878: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1894: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:2025: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2270: Function start_auth/1 has no local return
riakc_pb_socket.erl:2271: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.94s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

@thumbot
Copy link

thumbot commented Feb 21, 2017

enable_thumbs c1dd5bb ➡️ develop 87958bd ⛔ completed
There seems to be an issue with build step **make_dialyzer** ! ☁️
✅ MERGE

Started at: 2017-02-21 09:16
Duration: 1 seconds.
Result: OK
Message: Merge Success: enable_thumbs c1dd5bb onto target branch: develop 87958bd
Exit Code: OK

📄







  Merge made by the 'recursive' strategy.
 .thumbs.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .thumbs.yml




✅ MAKE_CLEAN

Started at: 2017-02-21 09:16
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make clean




  ./rebar clean
==> develop.87958bd.enable_thumbs.c1dd5bb (clean)





✅ MAKE_DEPS

Started at: 2017-02-21 09:16
Duration: 3 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make deps




  ./rebar get-deps
==> develop.87958bd.enable_thumbs.c1dd5bb (get-deps)
Pulling riak_pb from {git,"https://github.com/basho/riak_pb",{tag,"2.3.0.0"}}
Cloning into 'riak_pb'...
==> riak_pb (get-deps)
Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git",
                           {tag,"0.3.0-basho"}}
Cloning into 'hamcrest'...
==> hamcrest (get-deps)





✅ MAKE_COMPILE

Started at: 2017-02-21 09:16
Duration: 7 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make compile




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.87958bd.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
Compiled src/hamcrest.erl
Compiled src/hamcrest_term.erl
Compiled src/hamcrest_matchers.erl
==> hamcrest (post_compile)
==> riak_pb (compile)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_codec.erl
Compiled src/riak_pb_search_codec.erl
Compiled src/riak_pb_messages.erl
Compiled src/riak_pb_dt_codec.erl
Compiled src/riak_pb.erl
Compiled src/riak_dt_pb.erl
Compiled src/riak_ttb_codec.erl
Compiled src/riak_yokozuna_pb.erl
Compiled src/riak_pb_ts_codec.erl
Compiled src/riak_ts_pb.erl
Compiled src/riak_search_pb.erl
Compiled src/riak_kv_pb.erl
==> develop.87958bd.enable_thumbs.c1dd5bb (compile)
Compiled src/riakc_datatype.erl
Compiled src/riakc_ts_query_operator.erl
Compiled src/riakc_ts.erl
Compiled src/riakc_set.erl
Compiled src/riakc_hll.erl
Compiled src/riakc_ts_put_operator.erl
Compiled src/riakc_register.erl
Compiled src/riakc_ts_get_operator.erl
Compiled src/riakc_flag.erl
Compiled src/riakc_map.erl
Compiled src/riakc_utils.erl
Compiled src/riakc_gset.erl
Compiled src/riakc_counter.erl
Compiled src/riakc_obj.erl
Compiled src/riakc_pb_socket.erl





✅ MAKE_TEST

Started at: 2017-02-21 09:16
Duration: 83 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make test




  
  
... Snipped 144 lines ...
.........................................................(x100)....................................................................................................(x1000)..................(x100)......(x10)....(x1)...
Time limit reached: 2.0 seconds.

OK, passed 29743 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)................(x100)...(x10)........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 27488 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_map) ).......................................................................................................(x10)...........................................................................................................(x1).....
Time limit reached: 2.0 seconds.

OK, passed 1175 tests
[2.006 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_modified(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)..............................(x10).........
Time limit reached: 2.0 seconds.

OK, passed 4190 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100)..............................................................(x10)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 7346 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................(x10)......(x1)......
Time limit reached: 2.0 seconds.

OK, passed 8366 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................................................(x100)..(x10).....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 66356 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)...........................(x100)....(x1)......
Time limit reached: 2.0 seconds.

OK, passed 38506 tests
[2.000 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).................................(x100)..(x10)......(x1)...
Time limit reached: 2.0 seconds.

OK, passed 44363 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_map) ).......................................................................................................(x10)....................................................................................................(x100).....(x10)...(x1)....
Time limit reached: 2.0 seconds.

OK, passed 1634 tests
[2.010 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_is_type(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100)........................................................................................(x10).........
Time limit reached: 2.0 seconds.

OK, passed 9990 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_set) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10)...(x1).....
Time limit reached: 2.0 seconds.

OK, passed 8435 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_gset) ).......................................................................................................(x10)....................................................................................................(x100).........................................................................(x10)........(x1)....
Time limit reached: 2.0 seconds.

OK, passed 8484 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_counter) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)............................................(x100).......(x10).......(x1)........
Time limit reached: 2.0 seconds.

OK, passed 55878 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_flag) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000).......................(x100)..(x10)........(x1)....
Time limit reached: 2.0 seconds.

OK, passed 34384 tests
[2.001 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_register) ).......................................................................................................(x10)....................................................................................................(x100)....................................................................................................(x1000)........................(x100)........(x10).........(x1)........
Time limit reached: 2.0 seconds.

OK, passed 35998 tests
[2.002 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_map) ).......................................................................................................(x10)............................................................................................(x1)......
Time limit reached: 2.0 seconds.

OK, passed 1026 tests
[2.008 s] ok
  riakc_datatype:120: datatypes_test_ ( prop_module_for_term(riakc_hll) ).......................................................................................................(x10)....................................................................................................(x100).........................................(x10)..(x1).......
Time limit reached: 2.0 seconds.

OK, passed 5227 tests
[2.001 s] ok
  [done in 71.235 s]
module 'riakc_set'
module 'riakc_hll'
module 'riakc_obj'
  riakc_obj: bucket_test...ok
  riakc_obj: key_test...ok
  riakc_obj: invalid_key_test...ok
  riakc_obj: vclock_test...ok
  riakc_obj: newcontent0_test...ok
  riakc_obj: contents0_test...ok
  riakc_obj: contents1_test...ok
  riakc_obj: contents2_test...ok
  riakc_obj: update_metadata_test...ok
  riakc_obj: update_value_test...ok
  riakc_obj: updatevalue_ct_test...ok
  riakc_obj: update_content_type_test...ok
  riakc_obj: binary_content_type_test...ok
  riakc_obj: get_update_data_test...[0.001 s] ok
  riakc_obj: select_sibling_test...ok
  riakc_obj: user_metadata_utilities_test...ok
  riakc_obj: link_utilities_test...[0.001 s] ok
  riakc_obj: secondary_index_utilities_test...[0.001 s] ok
  [done in 0.058 s]
module 'riakc_pb_socket'
  riakc_pb_socket: increase_reconnect_interval_test...ok
  module 'riakc_pb_socket_tests'
    riakc_pb_socket_tests: listing_is_blocked_test...[0.001 s] ok
    riakc_pb_socket_tests: mapred_over_bucket_is_blocked_test...ok
    riakc_pb_socket_tests: bad_connect_test...[0.001 s] ok
    riakc_pb_socket_tests: queue_disconnected_test...[0.522 s] ok
    riakc_pb_socket_tests: auto_reconnect_bad_connect_test...ok
    riakc_pb_socket_tests: server_closes_socket_test...[0.006 s] ok
    riakc_pb_socket_tests: auto_reconnect_server_closes_socket_test...ok
    riakc_pb_socket_tests: dead_socket_pid_returns_to_caller_test...ok
    riakc_pb_socket_tests: adding_hll_to_map_throws_error_test...ok
test/riakc_pb_socket_tests.erl:1507:<0.392.0>: Skipped - needs live server
test/riakc_pb_socket_tests.erl:1507:<0.28963.0>: Skipped - needs live server
    [done in 0.651 s]
  [done in 0.654 s]
module 'riakc_register'
module 'riakc_gset'
=======================================================
  All 67 tests passed.
Cover analysis: /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb/.eunit/index.html





✅ MAKE_XREF

Started at: 2017-02-21 09:17
Duration: 5 seconds.
Result: OK
Message: OK
Exit Code: 0

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make xref




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.87958bd.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.87958bd.enable_thumbs.c1dd5bb (compile)
./rebar xref skip_deps=true
==> develop.87958bd.enable_thumbs.c1dd5bb (xref)





⛔ MAKE_DIALYZER

Started at: 2017-02-21 09:17
Duration: 73 seconds.
Result: ERROR
Message: Step make_dialyzer Failed!
Exit Code: 2

📄


cd /tmp/thumbs/develop.87958bd.enable_thumbs.c1dd5bb; make dialyzer




  ./rebar get-deps
==> hamcrest (get-deps)
==> riak_pb (get-deps)
==> develop.87958bd.enable_thumbs.c1dd5bb (get-deps)
./rebar compile
==> hamcrest (compile)
==> hamcrest (post_compile)
==> riak_pb (compile)
==> develop.87958bd.enable_thumbs.c1dd5bb (compile)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
done (passed successfully)
 yes
done (passed successfully)
  Creating PLT .local_dialyzer_plt ...
Unknown functions:
  application:get_env/2
  binary:copy/1
  dict:fold/3
  dict:from_list/1
  dict:store/3
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_term/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:integer_to_list/1
  erlang:iolist_to_binary/1
  erlang:is_process_alive/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_tuple/1
  erlang:term_to_binary/1
  error_logger:warning_msg/2
  eunit:test/1
  gb_sets:is_element/2
  gb_sets:is_empty/1
  gb_sets:is_set/1
  ordsets:is_element/2
  ordsets:is_set/1
  ordsets:size/1
  proplists:get_bool/2
  proplists:get_value/2
  proplists:get_value/3
  re:run/2
  sets:is_element/2
  sets:is_set/1
  sets:size/1
  string:equal/2
  string:join/2
  string:right/2
  string:str/2
Unknown types:
  proplists:property/0
 done in 0m56.74s
done (passed successfully)
==> develop.87958bd.enable_thumbs.c1dd5bb (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
riakc_pb_socket.erl:1746: Matching of pattern <{'request', _, {'rpbputreq', _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _}, _, _, _, _, _}, {'rpbputresp', 'undefined', 'undefined', Key}, State> tagged with a record name violates the declared type of #rpbputresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),key::'undefined' | binary()}
riakc_pb_socket.erl:1788: The pattern 'undefined' can never match the type [binary()]
riakc_pb_socket.erl:1856: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1878: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:1894: The pattern 'undefined' can never match the type [#rpbindexobject{key::'undefined' | binary(),object::'undefined' | #rpbgetresp{content::[#rpbcontent{value::'undefined' | binary(),content_type::'undefined' | binary(),charset::'undefined' | binary(),content_encoding::'undefined' | binary(),vtag::'undefined' | binary(),links::[#rpblink{bucket::'undefined' | binary(),key::'undefined' | binary(),tag::'undefined' | binary()}],last_mod::'undefined' | non_neg_integer(),last_mod_usecs::'undefined' | non_neg_integer(),usermeta::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],indexes::[#rpbpair{key::'undefined' | binary(),value::'undefined' | binary()}],deleted::'false' | 'true' | 'undefined' | 0 | 1,ttl::'undefined' | non_neg_integer()}],vclock::'undefined' | binary(),unchanged::'false' | 'true' | 'undefined' | 0 | 1}}]
riakc_pb_socket.erl:2025: The pattern 'undefined' can never match the type [#tsrow{cells::[#tscell{varchar_value::'undefined' | binary(),sint64_value::'undefined' | integer(),timestamp_value::'undefined' | integer(),boolean_value::'false' | 'true' | 'undefined' | 0 | 1,double_value::'-infinity' | 'infinity' | 'nan' | 'undefined' | number()}]}]
riakc_pb_socket.erl:2270: Function start_auth/1 has no local return
riakc_pb_socket.erl:2271: Record construction #rpbauthreq{user::string(),password::string()} violates the declared type of field user::'undefined' | binary() and password::'undefined' | binary()
 done in 0m3.97s
done (warnings were emitted)
make: *** [dialyzer-run] Error 2





⬜ 0 of 2 Code reviews from organization basho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants