Add -stdlib=libc++ flag when building snappy #258
Conversation
Signed-off-by: Peter Lemenkov <[email protected]>
These should only be appearing in riak.conf for documentation, as they won't be needed unless a user is setting up multi_backend. Even then they will probably want to change the backend name to something other than "name".
…pression-settings Make multi_backend compression settings commented
Don't use deprecated erlang:now/0 in tests
unsigned long for memory_sz so it compiles on scaleway C1 / arm
…ters. This fills some remaining race condition holes (of which one recently seen).
Switch to reference counted pointers instead of naked pointers.
Port submit_to_thread_queue() from riak_ts-develop to develop
…db operate correctly
Mv bucket expiry
…factor Backport submit_to_thread_queue() to KV
Refactor workitems.{h,cc}
Manually disabling dylib creation for snappy since OSX links the preferentially rather than the static library. This resolves basho#236
Disable shared library creation
A commit over 4 years ago disabled most of the eunit tests in the eleveldb module. This enables them and adds a few, while refactoring so they clean up after themselves. It also adds exported test helper functions to make it easier for other tests to clean up after themselves.
Tests now use helper functions from eleveldb module tests.
…time out on wimpy builders.
- Number of database instances is capped to keep filesystem footprint manageable. - Complexity of some operations reduced to limit runtime. - Generous timeouts added to more tests.
This value is an alternative to `-mmacosx-version-min=version` which does not appear to be settable via the snappy configure script. This is to allow support for historical versions of MacOSX
Added flag for MACOSX_DEPLOYMENT_TARGET = 10.8
…Doug and/or emacs happy (the former is the more worthy goal). Sync with latest 'develop' branch.
Test cleanup
… functions in router.cc.
MacOS >= 10.14 build fix
|
@mergefailure I don't see a PR by you. Do you mean #254? |
|
that’s right #254
On 11 Dec 2019, at 14:08, Jens Fischer ***@***.***> wrote:
@mergefailure I don't see a PR by you. Do you mean #254?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I saw #254 and I it would solve the problem more elegantly and would welcome if it gets merged. Given the low activity in this repo and the amount of changes in #254 my hopes for getting it merged any time soon are low. My PR is a minimally invasive fixup to an already merged PR (#245). My hope is that this has a slightly higher chance of getting merged. |
|
@jvf work to resolve various compatibility/build issues have been rolled into The There is a bit of a general problem with eleveldb wrt PRs and issues. There's no-one in the riak community who feels comfortable touching code (other than perhaps for very basic build changes like this). If there's someone out there who is more comfortable with pro-actively maintaining it, it might be an idea to request transfer of ownership out of the basho repo - as happened with lager and webmachine. |
AddendumFixup to #245, adding the-stdlib=libc++when building Snappy. This is necessary to build on macOS. Tested on macOS 10.14.6. See also #252 for the initial issue.