integrate open source expiry features into eleveldb option processing #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ if [ `uname -s` = 'SunOS' -a "${POSIX_SHELL}" != "true" ]; then | |||
| fi | |||
| unset POSIX_SHELL # clear it so if we invoke other scripts, they run as ksh as well | |||
|
|
|||
| LEVELDB_VSN="" | |||
| LEVELDB_VSN="mv-expiry" | |||
There was a problem hiding this comment.
Is this still needed? I think the mv-expiry branch of leveldb has been merged to develop.
There was a problem hiding this comment.
Good catch ... that is one of the classic eleveldb check-in screw ups.
Restored to default ""
|
+1 2f58433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically add an ExpiryModuleOS object to leveldb::Options if any one of the 3 expiry options seen. Only need one instance of the object and it will auto destruct after last pointer released.