remove aria-label on slides

basher · May 16, 2024 · 42524b4 · 42524b4
1 parent 86f4297
commit 42524b4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/ui/src/javascript/web-components/webui-carousel.ts b/ui/src/javascript/web-components/webui-carousel.ts
@@ -27,7 +27,6 @@ export default class WebUICarousel extends HTMLElement {
     }
 
     private init(): void {
-        // this.setupA11y();
         this.setVisibleSlide();
 
         // Show slide counter (text).
@@ -52,16 +51,6 @@ export default class WebUICarousel extends HTMLElement {
         this.handleKeyboard();
     }
 
-    private setupA11y(): void {
-        // Add slide counter labels for screen readers.
-        this.slides.forEach((slide: HTMLElement, i: number) => {
-            slide.setAttribute(
-                'aria-label',
-                `slide ${i + 1} of ${this.slides.length}`,
-            );
-        });
-    }
-
     private setVisibleSlide(): void {
         const observerSettings = {
             root: this.carousel,

diff --git a/ui/stories/6. Web Components Or Custom Elements/WebUI Carousel/WebUICarousel.mdx b/ui/stories/6. Web Components Or Custom Elements/WebUI Carousel/WebUICarousel.mdx
@@ -6,7 +6,6 @@ import * as WebUICarousel from './WebUICarousel.stories';
 # `<webui-carousel>`
 - This is an enhancement of the [default CSS carousel](/story/components-carousel--carousel) - optionally showing a slide count, PREV and NEXT buttons, etc.
 - Native scrolling with `LEFT|RIGHT` arrow keys is enhanced, allowing JavaScript to correctly update the slide count when using arrow keys.
-- Each slide has an `aria-label`, indicating the current slide number and the total number of slides.
 - When PREV and NEXT buttons are shown, keyboard `focus` is modified such that **only visible slides are focusable**.
 
 <Canvas of={WebUICarousel.WebUICarousel} />