Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement SDK #2

Merged
merged 15 commits into from
Dec 11, 2023
Merged

feat: implement SDK #2

merged 15 commits into from
Dec 11, 2023

Conversation

Goldziher
Copy link
Member

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Goldziher Goldziher merged commit 1104aa2 into main Dec 11, 2023
4 of 6 checks passed
@avinasht01
Copy link

1.Regarding BaseMindError, Is there any case which handles the error :Case Example - Unable to fetch prompt response for given input template variable due to insufficient data at llm end.
2. Regarding BaseMindClientTests, The server certificate, key, cacert were added in test class file, this can be moved to some other file.
3.Default constants like DEFAULT_API_GATEWAY_ADDRESS, etc can be moved to some constants file.
4.Missing function definitions can be added.

@Goldziher
Copy link
Member Author

1.Regarding BaseMindError, Is there any case which handles the error :Case Example - Unable to fetch prompt response for given input template variable due to insufficient data at llm end.

This would be a .serverError - that is, equal to a 500 I'm REST.

  1. Regarding BaseMindClientTests, The server certificate, key, cacert were added in test class file, this can be moved to some other file.

Sure

3.Default constants like DEFAULT_API_GATEWAY_ADDRESS, etc can be moved to some constants file.

If it was a bigger application, sure. In this case I think it's fine.

4.Missing function definitions can be added.

Can you explain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants