feat(infrastructure): setup mock db env #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yatanvesh
force-pushed
the
BM-0001-tests
branch
from
b4d02b4
to
80023db
Compare
Yatanvesh
commented
Aug 27, 2023
Yatanvesh
force-pushed
the
BM-0001-tests
branch
from
80023db
to
50cf682
Compare
Coverage Report
File CoverageNo changed files found. |
Yatanvesh
commented
Aug 28, 2023
| func HandleDashboardUserPostLogin(w http.ResponseWriter, r *http.Request) { | ||
| firebaseId := r.Context().Value(constants.FireBaseIdContextKey).(string) | ||
|
|
||
| if userExists, queryErr := db.GetQueries().CheckUserExists(r.Context(), firebaseId); queryErr != nil { | ||
| log.Error().Err(queryErr).Msg("failed to retrieve user") | ||
| dbQueries := db.GetQueries() |
There was a problem hiding this comment.
i get the other 2 funcs, what about mocking dbQueries for this guy
There was a problem hiding this comment.
i was wrong, db.Queries is actually a struct - not an interface. We cannot mock it.
What we can do is add an abstraction layer, and then mock it. But I think this is an overkill for now.
Yatanvesh
commented
Aug 28, 2023
Goldziher
force-pushed
the
BM-0001-tests
branch
from
7c3f579
to
15a6adf
Compare
Goldziher
force-pushed
the
BM-0001-tests
branch
from
15a6adf
to
8f6d3ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.