-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated containers, unified styles and refactored prompt-config wizard #216
Conversation
PR Analysis(review updated until commit 8ddc209)
PR Feedback
How to useInstructions
|
/review |
Persistent review updated to latest commit 8ddc209 |
...locale]/projects/[projectId]/applications/[applicationId]/config-create-wizard/page.spec.tsx
Outdated
Show resolved
Hide resolved
...ojects/[projectId]/applications/[applicationId]/configs/[configId]/prompt-config-testing.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the major problem with this PR is that it mixes two concerns -
- general style fixes
- changes to the wizard
I would like you to split it into two separate PRs that do two different things. You can have one PR pointing at the other, that's not a problem (obviously the style fixes should be first).
/improve --extended |
d761c56
to
e5c64ed
Compare
...app/[locale]/projects/[projectId]/applications/[applicationId]/config-create-wizard/page.tsx
Outdated
Show resolved
Hide resolved
...app/[locale]/projects/[projectId]/applications/[applicationId]/config-create-wizard/page.tsx
Outdated
Show resolved
Hide resolved
...ponents/projects/[projectId]/applications/[applicationId]/config-create-wizard/base-form.tsx
Outdated
Show resolved
Hide resolved
...[projectId]/applications/[applicationId]/config-create-wizard/prompt-config-testing-form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Na'aman Hirschfeld <[email protected]>
No description provided.