Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove android #213

Merged
merged 7 commits into from
Nov 30, 2023
Merged

chore: remove android #213

merged 7 commits into from
Nov 30, 2023

Conversation

Goldziher
Copy link
Member

This PR removes Android from this repo - since its all moved to a new repo

@Goldziher Goldziher merged commit dc84efe into main Nov 30, 2023
6 of 9 checks passed
@Goldziher Goldziher deleted the android-sdk-release branch November 30, 2023 14:44
Copy link

PR Analysis

  • 🎯 Main theme: Removal of Android from the repository
  • 📝 PR summary: This PR removes Android from the repository since it has been moved to a new repository.
  • 📌 Type of PR: Other
  • 🧪 Relevant tests added: False
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR mainly involves removing code and dependencies.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: It would be helpful to provide more context in the PR description about why Android was removed and where it can be found now.

  • 🤖 Code feedback:
    • relevant file: frontend/package.json
      suggestion: Consider updating the version of "@segment/analytics-next" to the latest stable version. [medium]
      relevant line: "@segment/analytics-next": "^1.62.0"

    • relevant file: .idea/runConfigurations/test_app.xml
      suggestion: Remove the "activateToolWindowBeforeRun" and "singleton" attributes from the element. [medium]
      relevant line:

    • relevant file: .idea/runConfigurations/sdks_android_test_app.xml
      suggestion: Update the "languageLevel" attribute to "JDK_1_8" to match the project's language level. [medium]
      relevant line:

    • relevant file: .idea/misc.xml
      suggestion: Remove the declaration from the file. [medium]
      relevant line:

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant