Skip to content

Commit

Permalink
Remove undocumented *args and **kwargs" from GUI class initializers. (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
bartfeenstra authored Feb 20, 2024
1 parent cc5b14d commit 9d188f7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 20 deletions.
9 changes: 4 additions & 5 deletions betty/gui/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Provide logging for the Graphical User Interface.
"""
import logging
from typing import Any

from PyQt6.QtCore import QObject, pyqtSignal, Qt
from PyQt6.QtWidgets import QWidget, QVBoxLayout
Expand All @@ -22,8 +21,8 @@ class LogRecord(Text):

_formatter = logging.Formatter()

def __init__(self, record: logging.LogRecord, *args: Any, **kwargs: Any):
super().__init__(self._formatter.format(record), *args, **kwargs)
def __init__(self, record: logging.LogRecord):
super().__init__(self._formatter.format(record))
self.setProperty('level', self._normalize_level(record.levelno))

def _normalize_level(self, record_level: int) -> int:
Expand All @@ -34,8 +33,8 @@ def _normalize_level(self, record_level: int) -> int:


class LogRecordViewer(QWidget):
def __init__(self, *args: Any, **kwargs: Any):
super().__init__(*args, **kwargs)
def __init__(self):
super().__init__()
self._log_record_layout = QVBoxLayout()
self.setLayout(self._log_record_layout)

Expand Down
29 changes: 14 additions & 15 deletions betty/gui/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from asyncio import Task
from contextlib import suppress
from pathlib import Path
from typing import Any
from urllib.parse import urlparse

from PyQt6.QtCore import Qt, QThread, QObject
Expand Down Expand Up @@ -39,8 +38,8 @@


class _PaneButton(QPushButton):
def __init__(self, pane_name: str, project_window: ProjectWindow, *args: Any, **kwargs: Any):
super().__init__(*args, **kwargs)
def __init__(self, pane_name: str, project_window: ProjectWindow):
super().__init__()
self.setFlat(True)
self.setProperty('pane-selector', 'true')
self.setCursor(Qt.CursorShape.PointingHandCursor)
Expand All @@ -50,8 +49,8 @@ def __init__(self, pane_name: str, project_window: ProjectWindow, *args: Any, **


class _GenerateHtmlListForm(LocalizedObject, QWidget):
def __init__(self, app: App, *args: Any, **kwargs: Any):
super().__init__(app, *args, **kwargs)
def __init__(self, app: App):
super().__init__(app)
self._form = QFormLayout()
self.setLayout(self._form)
self._form_label = QLabel()
Expand Down Expand Up @@ -99,8 +98,8 @@ def _set_translatables(self) -> None:


class _GeneralPane(LocalizedObject, QWidget):
def __init__(self, app: App, *args: Any, **kwargs: Any):
super().__init__(app, *args, **kwargs)
def __init__(self, app: App):
super().__init__(app)

self._form = QFormLayout()
self.setLayout(self._form)
Expand Down Expand Up @@ -206,8 +205,8 @@ def _set_translatables(self) -> None:


class _LocalesConfigurationWidget(LocalizedObject, QWidget):
def __init__(self, *args: Any, **kwargs: Any):
super().__init__(*args, **kwargs)
def __init__(self, app: App):
super().__init__(app)

self._layout = QGridLayout()
self.setLayout(self._layout)
Expand Down Expand Up @@ -260,8 +259,8 @@ def _set_translatables(self) -> None:


class _LocalizationPane(LocalizedObject, QWidget):
def __init__(self, app: App, *args: Any, **kwargs: Any):
super().__init__(app, *args, **kwargs)
def __init__(self, app: App):
super().__init__(app)

self._layout = QVBoxLayout()
self.setLayout(self._layout)
Expand Down Expand Up @@ -367,8 +366,8 @@ def _save_and_close_locale(self) -> None:


class _ExtensionPane(LocalizedObject, QWidget):
def __init__(self, app: App, extension_type: type[UserFacingExtension], *args: Any, **kwargs: Any):
super().__init__(app, *args, **kwargs)
def __init__(self, app: App, extension_type: type[UserFacingExtension]):
super().__init__(app)
self._extension_type = extension_type

layout = QVBoxLayout()
Expand Down Expand Up @@ -591,8 +590,8 @@ def _serve(self) -> None:


class _GenerateThread(QThread):
def __init__(self, project: Project, generate_window: _GenerateWindow, *args: Any, **kwargs: Any):
super().__init__(*args, **kwargs)
def __init__(self, project: Project, generate_window: _GenerateWindow):
super().__init__()
self._project = project
self._generate_window = generate_window
self._task: Task[None] | None = None
Expand Down

0 comments on commit 9d188f7

Please sign in to comment.