Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunnel support via @shopify/plugin-cloudflare #154

Merged
merged 21 commits into from
Nov 6, 2024
Merged

Conversation

montalvomiguelo
Copy link
Collaborator

@montalvomiguelo montalvomiguelo commented Sep 27, 2024

Fixes #152

Enables the creation of Cloudflare Quick Tunnels during dev, allowing previews from any device.

🚀 Snapshot: [email protected]

plugin-cloudflare.mp4

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for bespoke-flan-5eacfc canceled.

Name Link
🔨 Latest commit 7c7fdc4
🔍 Latest deploy log https://app.netlify.com/sites/bespoke-flan-5eacfc/deploys/671d61906e5ae400082eb215

@montalvomiguelo montalvomiguelo changed the title Tunnel support Tunnel support via @shopify/plugin-cloudflare Sep 28, 2024
@montalvomiguelo montalvomiguelo changed the title Tunnel support via @shopify/plugin-cloudflare Tunnel support via @shopify/plugin-cloudflare Sep 28, 2024
@montalvomiguelo montalvomiguelo marked this pull request as ready for review September 29, 2024 04:28
@tuanpham-barrel
Copy link
Collaborator

@montalvomiguelo @wturnerharris - This looks good to me.
Only one thing, when I run 2 tasks vite dev and shopify theme dev in parallel, the tunnel message displays as the the last message. This is confusing because I don't know if this is for vite or shopify preview. I think we can update the message to something clearer like "http://localhost:5173 is tunneled to https://xyz.trycloudflare.com"

2024-10-24_14-56

@montalvomiguelo
Copy link
Collaborator Author

montalvomiguelo commented Oct 26, 2024

updated

Screenshot 2024-10-26 at 3 17 47 PM

@montalvomiguelo montalvomiguelo merged commit dbeb35d into main Nov 6, 2024
11 checks passed
@montalvomiguelo
Copy link
Collaborator Author

@wturnerharris let's ship this? 🚀

@montalvomiguelo montalvomiguelo deleted the feat/tunnels branch December 20, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ngrok/cloudflare asset tunnel
2 participants