FEA-3357 - Fixed title attribute display #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made title safe for both tab content and title attribute Fixed attribute title when title has entities
|
Related task: https://barchartsolutions.atlassian.net/browse/FEA-3357 |
|
@djelovic do you want to review and approve PRs submitted by @goranurukalo in the beginning as he is getting acquainted with the cmdtyView code base? Additionally, do you know if we merge this PR if it gets picked up by the main cmdtyView branch? |
|
This one too @djelovic as a friendly reminder. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made title safe for both tab content and title attribute
Fixed attribute title when title has entities
Didn't run
gulp buildto build all upnot sure about the procedure of bumping up versions
or if we bulk update at the end of the sprint
If anything needed, ill gladly update it