Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(remove dts): Remove the the use of DTS files #26

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

miguelafsilva5
Copy link
Member

@miguelafsilva5 miguelafsilva5 commented Mar 6, 2024

PR Description

DTS files were previously used to define the following variables: tests, suites, platform, nix recipe, log and echo levels. Since the latter two variables were moved to command line options. The use of an additional file just to define effectively 3 variables, was starting to become overkill. Furthermore, in order to specify different tests and suites for different guests, would require increasing the complexity of the DTS file.

As such, we opted to move the definition of which test and suite runs on which guest to the nix recipe. Both nix recipe and platform are now passed to the framework via command line. This concentrates all configurations in a single file/recipe.

The expected command to execute the framework is:
python3 test_framework.py -recipe PATH/TO/RECIPE.nix -platform SUPPORTED_PLATFORM

And an example of a guest definition in a nix recipe:

    guests = [
          (callPackage (../../bao-nix/pkgs/guest/baremetal-remote-tf.nix)
                  { 
                    inherit system-cfg;
                    inherit toolchain;
                    guest_name = "baremetal";
                    list_tests = "";
                    list_suites = "BASIC";
                    inherit log_level;            
                  }
          )
      ];

Diogo21Costa
Diogo21Costa previously approved these changes Mar 7, 2024
@ESCristiano ESCristiano merged commit 058e58f into main Mar 11, 2024
5 checks passed
@ESCristiano ESCristiano deleted the feat/remove-dts branch March 11, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants