Feat(riscv-launcher): Add a launcher to qemu-riscv64-virt #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelafsilva5
force-pushed
the
feat/riscv-launch
branch
2 times, most recently
from
9280426
to
229598e
Compare
Diogo21Costa
previously approved these changes
Mar 7, 2024
Add a different launch option for qemu-riscv64-virt that finds the openSBI elf and executes a different script. Also, removed the code regarding the connection to outside of the if statements Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
miguelafsilva5
force-pushed
the
feat/riscv-launch
branch
from
229598e
to
c82a5c3
Compare
Diogo21Costa
approved these changes
Mar 8, 2024
ESCristiano
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces a way to launch qemu for riscv64-virt based on the platform defined in the DTS file.
This is achieve by modifying the main python script and separating the qemu-riscv64-virt platform from qemu-aarch64-virt launch condition.
It introduces a new launch script dedicated to this platform. Furthermore, the script for qemu-aarch64-virt was moved to the new directoy launch, where ideally all launch scripts will be placed. The new directory is more intuitive and better describes its purpose. Additionally, it helps futureproofing the framework.