Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse): update tests and suites lists parsing #19

Closed
wants to merge 1 commit into from

Conversation

Diogo21Costa
Copy link
Member

This PR addresses a minor issue related to parsing the list of tests and suites in the config.dts files. Previously, there was a bug where parsing multiple suites and/or tests was not functioning correctly. For example, consider the following config.dts file:

/dts-v1/;
/ {
    platform = "qemu-aarch64-virt";
    log_echo = <1>;

    test_config {
        recipe_test {
            nix_file = "default.nix";
            suites = "SUCCESS_SUITE FAIL_SUITE";
            tests = "";
            log_level = "0";
        };
    };
};

Running the Nix build system with the command:

nix-build default.nix --argstr platform qemu-aarch64-virt --argstr list_suites "SUCCESS_SUITE FAIL_SUITE"

would result in the following error:

make: *** No rule to make target 'FAIL_SUITE'.  Stop.

With the changes introduced in this pull request, the corrected build command now looks like:

nix-build default.nix --argstr platform qemu-aarch64-virt --argstr list_suites "SUCCESS_SUITE\ FAIL_SUITE"

Please review and provide any comments or suggestions.

miguelafsilva5
miguelafsilva5 previously approved these changes Jan 30, 2024
@miguelafsilva5
Copy link
Member

If I'm not mistaken, someone suggested to have multiple strings instead of a single string with all suite.
E.g.: suites: "SUCCESS_SUITE", "FAIL_SUITE";

@Diogo21Costa
Copy link
Member Author

@miguelafsilva5 you're right. In fact, in #22 the changes suppress this PR by implementing those changes. Maybe we should close this PR and proceed with the other one, right?

@miguelafsilva5
Copy link
Member

@miguelafsilva5 you're right. In fact, in #22 the changes suppress this PR by implementing those changes. Maybe we should close this PR and proceed with the other one, right?

I don't think so. Ideally, both PR implement distinct features. It seems that #22 intends to be a PR dealing with the log and echo levels while this one aims to deal with parsing the suites and tests. No need to add unrelated features to other PRs when it can be done in the proper one.

@miguelafsilva5
Copy link
Member

miguelafsilva5 commented Feb 19, 2024

Closed this PR as this changes are already in #22. And they the dts files will be removed from the current framework.

@Diogo21Costa Diogo21Costa deleted the fix/tests_parsing branch February 22, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants