feat(firmware_recipes): Add firmware recipes according to platform #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This recipe assigns atf and u-boot as its dependencies forcing their builds through their own recipes. During the installPhase, this recipe copies the binaries generated to proper directory. Signed-off-by: Miguel Silva <[email protected]>
This recipe assigns openSBI as its dependency forcing its build through its own recipe. During the installPhase, this recipe copies the binaries generated to proper directory. Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
Diogo21Costa
approved these changes
Feb 29, 2024
ESCristiano
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces 2 new recipes for the firmware of currently supported platforms (qemu-aarch64-virt and qemu-riscv64-virt).
The goal of this PR is to ease process of developing and understanding/reading the main recipes (up until this points, these were the default.nix). Instead of requiring the user to specify which firmware packages are required in the top level, the idea is to have the firmware recipe selected according to the platform (variable passed to nix via command line, either in the python or make commands). Following is the ideal application of these recipes in a default.nix.
Furthermore, it removes an unused variable from the openSBI inputs. This was causing errors for the new recipes as these do not have access to the bao package.