Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(bao_recipe): update local/remote srcs assignment #7

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Diogo21Costa
Copy link
Member

PR Description

This PR refactors the logic for assigning the srcs attribute in the Bao Nix recipe.

The recipe is typically used with the following syntax:

bao = callPackage (nix_pkgs_path + "/bao/bao.nix")            { 
              toolchain = aarch64-none-elf;
              bao_srcs_path = /path/to/bao/repo;
              inherit bao_cfg_repo;
              inherit bao_cfg;
              platform_cfg = plat_cfg;
              inherit guests;
            };

If bao_srcs_path is defined, the build of Bao uses local sources. If bao_srcs_path is not defined, the code is fetched from GitHub, and remote sources are used.

This change allows a single nix recipe for building the hypervisor, either local or remote sources.

Please provide your feedback on these changes.

@ESCristiano ESCristiano merged commit 4d54d42 into update/bao-recipes Feb 23, 2024
2 checks passed
@ESCristiano ESCristiano deleted the feat/conditional_srcs_path branch February 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants