feat(armv8/psci): Handle unexpected psci behavior #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielRep
previously approved these changes
Sep 27, 2024
|
@DavidMCerdeira Shouldn't we address other calls to |
Merged
|
This is a good point |
Please make sure we are also inline with the PSCI in this respect. |
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
from
14d8cc1
to
2f33b23
Compare
DavidMCerdeira
changed the title
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
3 times, most recently
from
a981972
to
93d03a6
Compare
DavidMCerdeira
changed the title
josecm
requested changes
Oct 2, 2024
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
from
93d03a6
to
7fa7b46
Compare
We've observed that some platforms behave unexpectedly when performing power down. In these cases, after powerdown, the CPU cores are not awaken by interrupts as expected by Bao. This commit solve this, by adding the ability to skip the powerdown firmware call, instead relying on the fallback mechanism of using standby. Signed-off-by: David Cerdeira <[email protected]>
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
from
7fa7b46
to
aeeaa2c
Compare
danielRep
previously approved these changes
Oct 3, 2024
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
from
aeeaa2c
to
d5ec70b
Compare
The development target zcu104/zcu102 and Ultra96 does not wake up on interrupts after emiting PSCI standby calls to TF-A. We should understand why. To circunvent this, we allow platforms to declare standby is not supported and fallback to wfi. Signed-off-by: David Cerdeira <[email protected]>
DavidMCerdeira
force-pushed
the
feat/psci-powerdown
branch
from
d5ec70b
to
43c4321
Compare
josecm
approved these changes
Oct 3, 2024
danielRep
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed that some platforms behave unexpectedly when performing power down, and others when performing standby. In these cases, the CPU cores are not awaken by interrupts as expected. These commit solve this, by adding the ability to skip the respective firmware call, instead relying on the fallback mechanism of using wfi.