Allow for ci submodule not be present #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecm
requested review from
sandro2pinto,
DavidMCerdeira and
danielRep
as code owners
josecm
changed the title
danielRep
previously approved these changes
Aug 19, 2024
If this reposiroty is not cloned with '--recursive', the ci subdmoudle will not be prenset which will result in any invocation of make to fail. This modification allows that if the ci submodule is not present, it will simply be ignored and typical make calls for building the hypervisor will continue normally. Signed-off-by: Jose Martins <[email protected]>
josecm
force-pushed
the
feat/ignore_missing_ci_submodule
branch
from
5c28387
to
b05a37e
Compare
danielRep
approved these changes
Aug 20, 2024
DavidMCerdeira
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this reposiroty is not cloned with '--recursive', the ci subdmoudle will not be prenset which will result in any invocation of make to fail. This modification allows that if the ci submodule is not present, it will simply be ignored and typical make calls for building the hypervisor will continue normally.