fix(armv8/vgic): fix comparison on pend_found #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huang Yuxin <[email protected]>
|
I'm not sure this fix is correct. The logic here is that if we found more than one pending interrupt in the list registers, we can replace one of them because, as suggested by the GIC spec, if there are any pending interrupts, at least one pending interrupt should be in the list. Do you agree @Clara-Huang @DavidMCerdeira ? |
|
@Clara-Huang I'm closing this for now, unless there is any new arguments that can convince me my rationale is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a suitable pending interrupt is found, it should be replaced rather than checking if
pend_foundis greater than 1. Thus, I have changed> 1to>= 1.If my understanding is incorrect, I will close this PR. Thank you for your review!